Ticket #3056 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Check TofEvent() constructor usage in tests.

Reported by: Stuart Campbell Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

I noticed some warnings related to calls (mainly in tests) to create an event such as 

TofEvent(1.5, 2.3)

The constructor looks like it takes a (double, int64_t). I was wondering why 2.3 is used for an integer value.

I haved fixed the warning for the moment with a cast, but I am probably missing something so I'm creating the ticket for you, so you can have a look.

Change History

comment:1 Changed 9 years ago by Stuart Campbell

(In [11901]) refs #2897 & #3056

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12084]) Fixes #3056: TofEvent() constructors fixed to use int for pulsetime in a couple of places.

comment:4 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:5 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3903

Note: See TracTickets for help on using tickets.