Ticket #3102 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Goniometer: Add method to get Euler angles from a rot. matrix

Reported by: Janik Zikovsky Owned by: Andrei Savici
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

... convert from Python

Change History

comment:1 Changed 9 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Andrei Savici

(In [12145]) Added decomposition of a matrix to a rotation and a scale. Needed for Goniometer. Refs #3102

comment:3 Changed 9 years ago by Andrei Savici

(In [12149]) Windows fix. Added isRotation function. Needed for Goniometer. Refs #3102

comment:4 Changed 9 years ago by Janik Zikovsky

(In [12176]) Refs #3102: Test (currently disabled because it fails) for the rotation matrix of a Quat

comment:5 Changed 9 years ago by Janik Zikovsky

(In [12213]) Refs #3102, test for goniometer that currently fails (disabled).

comment:6 Changed 9 years ago by Andrei Savici

(In [12227]) Fix Quat to matrix, to follow physics convention as on wikipedia, as opposed to computer graphics convention. Refs.#3102

comment:7 Changed 9 years ago by Andrei Savici

(In [12242]) Function prototype for getting Euler Angles. Refs.#3102

comment:8 Changed 9 years ago by Janik Zikovsky

(In [12243]) Refs #3102: test for GetEulerAngle(), fixes to universalGoniometers. Also refs #3122: Cxxtest got confused by a commented-out performance test.

comment:9 Changed 9 years ago by Janik Zikovsky

(In [12260]) Fixes #3087: LoadIsawUB works to a round trip. Refs #3012: Fix universalGoniometer in Goniometer class to use the right rotations. Refs #2897: fixed a couple of warnings.

comment:10 Changed 9 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12261]) Fixes #3102

comment:11 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:12 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

There is a unit test covering this work, so if anything goes wrong, we should know.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3949

Note: See TracTickets for help on using tickets.