Ticket #3117 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

IQTransform: should allow negative intensities

Reported by: Michael Whitty Owned by: Nick Draper
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Steve King reports that the IQTransform algorithm should be able to deal with input workspaces that contain negative intensities while still giving a result.

Change History

comment:1 Changed 9 years ago by Michael Whitty

  • Owner set to Michael Whitty
  • Status changed from new to assigned

Do this by adding a second Log() functor to VectorHelper which does not throw when value <= 0.

comment:2 Changed 9 years ago by Michael Whitty

  • Status changed from assigned to accepted

comment:3 Changed 9 years ago by Michael Whitty

(In [12252]) refs #3117 - add LogNoThrow operation to VectorHelper, use in IQTransform algorithm.

comment:4 Changed 9 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

this is done.

comment:5 Changed 9 years ago by Nick Draper

  • Owner changed from Michael Whitty to Martyn Gigg

Moved from Michael Whitty, ask Martyn if you have any questions during testing

comment:6 Changed 9 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Nick Draper

Moved so they can be tested

comment:7 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified that IQTransform now uses the LogNoThrow functor.

Running a SANS reduction, manually setting values to negative numbers and running IQTransform no longer produces an error. The output seems to be zero in the places where negative numbers are given but it has to be something if it is not an error and that seems as good as anything.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3964

Note: See TracTickets for help on using tickets.