Ticket #3160 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make a decision on merging or keeping separate Nexus/DataHandling

Reported by: Martyn Gigg Owned by: Stuart Campbell
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Recently a change to DataHandling/LoadRaw/isisraw2 caused a strange failure on the intel compiler. It was if the code had not been put in. This was down to the fact that there was a separate copy of the isisraw structures in the NeXus package used by SaveISISNeXus and they were not updated.

We should make decision on whether we keep DataHandling and Nexus separate of not. If we are merging them then we only need to keep one copy but if we are not we should put isisraw2.cpp/h somewhere accessible to both so that this does not happen again.

Change History

comment:1 Changed 9 years ago by Russell Taylor

See #2822.

comment:2 Changed 9 years ago by Stuart Campbell

  • Owner set to Stuart Campbell
  • Status changed from new to assigned

comment:3 Changed 9 years ago by Stuart Campbell

  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Stuart Campbell

  • Summary changed from Make a decisison on merging or keeping separate Nexus/DataHandling to Make a decision on merging or keeping separate Nexus/DataHandling

comment:5 Changed 9 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12748]) Remove LoadRaw stuff in Nexus package from build. Had to do a dirty hack and make the logger not static for it to work. refs #2822 and fixes #3160

comment:6 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:7 Changed 9 years ago by Stuart Campbell

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [12749]) Remove LoadRaw directory from Nexus. fixes #2822 & #3160

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Sort of a duplicate of #2822, which is closed. Only the Nexus API type routines seem to remain in the Nexus folder.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4007

Note: See TracTickets for help on using tickets.