Ticket #3224 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make LoadEventPreNeXus faster

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

What do you think the work is?

As a reference: PG3_4289_neutron_event.dat is 1.3GB in size and takes roughly two minutes.

Change History

comment:1 Changed 9 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Peter Peterson

(In [12804]) Removing unused variable. Refs #3224.

comment:3 Changed 9 years ago by Peter Peterson

(In [12805]) Use a vector rather than a map if you are going to pad empty pixels. Refs #3224.

comment:4 Changed 9 years ago by Peter Peterson

(In [12806]) Removed the option to not pad empty pixels and added a way to limit number of events to read in. Refs #3224.

comment:5 Changed 9 years ago by Peter Peterson

(In [12808]) Got rid of padding in tests and commented out the failing tests (for now). Refs #3224.

comment:6 Changed 9 years ago by Peter Peterson

(In [12810]) Commenting out the other failing tests that use loadprenexus until I can fix them all. Refs #3224.

comment:7 Changed 9 years ago by Peter Peterson

(In [12821]) Adding EventList::empty() as it is useful in another bit of code. Refs #3224.

comment:8 Changed 9 years ago by Peter Peterson

(In [12822]) New function to delete empty EventLists on demand. Refs #3224.

comment:9 Changed 9 years ago by Peter Peterson

(In [12823]) Various fixes that should make things better. This includes reworking a couple of tests that are meaningfully different. Refs #3224.

comment:10 Changed 9 years ago by Peter Peterson

(In [12824]) Fixed broken test. Refs #3224.

comment:11 Changed 9 years ago by Peter Peterson

(In [12825]) Fixed broken test. Refs #3224.

comment:12 Changed 9 years ago by Peter Peterson

(In [12827]) Fixed broken test. Refs #3224.

comment:13 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:14 Changed 9 years ago by Peter Peterson

  • Milestone changed from Iteration 30 to Iteration 29

comment:15 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:17 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Confirmed: SEQ_8684_event.nxs used to load in 54.4 secs (release) and now takes 29.8 seconds.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4071

Note: See TracTickets for help on using tickets.