Ticket #3236 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

EventNexusReader XML not being updated

Reported by: Michael Reuter Owned by: Owen Arnold
Priority: critical Milestone: Iteration 29
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

After changing values like the number of bins or axis bounds, the XML associated with the dataset is not being update. When asked, the dataset returns the values that were present upon file load.

Change History

comment:1 Changed 9 years ago by Michael Reuter

  • type changed from enhancement to defect

comment:2 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Owen Arnold

(In [12834]) re #3236. There was an issue with the EventNexusReader.xml. Legacy elements provided hooks for specifying the number of bins in X, Y, Z, that did not actually have event handlers. Possible therefore that users/testers were modifying these rather than the ones below associated with dimensions (generated via DimensionWidgets).

However, inspection of the xml at runtime reveals that all the information provided in the GUI, is being carried through.

comment:4 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:6 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

I think this refers to the bins # resetting when you change Qx Qy Qz in the combo boxes, and this looks fixed.

comment:7 Changed 9 years ago by Owen Arnold

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:8 Changed 9 years ago by Owen Arnold

  • Status changed from reopened to accepted

comment:9 Changed 9 years ago by Owen Arnold

(In [12908]) re #3236. XML is now updated with dimension ranges.

comment:10 Changed 9 years ago by Owen Arnold

(In [12909]) re #3236. Sorry forgot to commit updated tests.

comment:11 Changed 9 years ago by Owen Arnold

(In [12912]) re #3236. Fix broken tests on linux.

comment:12 Changed 9 years ago by Owen Arnold

(In [12913]) re #3236. Should correctly store updated geometry aspects.

comment:13 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

This should be working now. To test, in the EventNexusReader:

1)Change the min and max limits for each dimension.

2)Apply

3)Go to multislice view. Axis should have the same limits as those set for the dimensions in (1).

comment:14 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Michael Reuter

comment:15 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

I have verified this via the simple interface.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4083

Note: See TracTickets for help on using tickets.