Ticket #4858 (closed: fixed)
In GausDecay ensure Sigma is never negative.
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jose Borreguero |
Description (last modified by Samuel Jackson) (diff)
The GausDecay fitting function currently returns a negative sigma value for its unit test. Since sigma is the square root of a quantity, its sign does not matter. However, I believe a positive sign is preferred.
This may be done by using constriants.
Change History
comment:2 Changed 9 years ago by Karl Palmen
- Status changed from new to assigned
- Owner set to Karl Palmen
comment:3 Changed 9 years ago by Karl Palmen
This can be fixed by using Active Parameter in a similar manner as what Gaussian does.
comment:5 Changed 9 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
Fixed for both GausDecay and GausOsc by using SetActiveParameter.
comment:6 Changed 8 years ago by Jose Borreguero
- Status changed from verify to verifying
- Tester set to Jose Borreguero
comment:8 Changed 7 years ago by Samuel Jackson
Refs #4858 Add spectrum range options to interface.
Changeset: 108e45a94194a3731a1236378fdb39af73fac724
comment:9 Changed 7 years ago by Samuel Jackson
Refs #4858 Add validation to interface options.
Changeset: daae0dd66d068820a300a09763dac9fc2239b236
comment:10 Changed 7 years ago by Samuel Jackson
Refs #4858 Hook options up to python code.
Changeset: f811c0e3823fb470059b4330e59595ca8d56ae5f
comment:11 Changed 7 years ago by Samuel Jackson
Refs #4858 Add sequential fit option.
Changeset: f32450405a8fe1db386844f2d96244a0f156d7f8
comment:12 Changed 7 years ago by Samuel Jackson
Refs #4858 Hook sequential fit option up to python script.
Changeset: e47d442ae4448d8bfeb2174ee50ac5664f899f03
comment:13 Changed 7 years ago by Samuel Jackson
Refs #4858 Don't plot graph with single data point.
Changeset: e9246bc7170abedb3de56ba943b063e096754e26
comment:14 Changed 7 years ago by Samuel Jackson
- Description modified (diff)
The above commits were added with the wrong ticket number. They should be on ticket #4856. I've copied the comments there.
comment:15 Changed 6 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/feature/4858_msdfit_ui_upgrade'
Full changeset: 86f0ffdbeffd224ad800ffe2c8ac26b12a3ce7c4
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5705
The same situation applies to GausOsc. Roman has put a temporary fix for it in the unit test GausOscTest.h .