Ticket #5050 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

EnabledWhenProperty segfaults if the property is also in a group.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Release 2.1
Component: Mantid Keywords:
Cc: m2d@… Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Janik Zikovsky) (diff)

e.g. DetectorDiagnostic.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Owner changed from Janik Zikovsky to Roman Tolchenov
  • Status changed from accepted to assigned
  • Description modified (diff)

Hi Roman, I created a ticket for this issue with EnabledWhenProperty...

comment:3 Changed 9 years ago by Janik Zikovsky

  • Owner changed from Roman Tolchenov to Janik Zikovsky
  • Status changed from assigned to accepted

comment:4 Changed 9 years ago by Janik Zikovsky

Refs #5050 fix segfault where EnabledWhenProperty was used

Instead of trying to keep an up-to-date ptr to Algorithm, just pass the right one as late as possible. No more trouble with AlgorithmProxy

Changeset: 0a442fa81e43dbd4cfce39e41d6d627e94fc02f0

comment:5 Changed 9 years ago by Janik Zikovsky

Refs #5050 fix some tests

Changeset: bdaabfe56c095b1a70f298e188f0f278297e7f3e

comment:6 Changed 9 years ago by Janik Zikovsky

Refs #5050 remove algorithm * from IPropertySettings constructors

so changed all algorithms that used it.

Changeset: a20a166a1b5e43627a51385de258e5933377882b

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Testers: Under RHEL6, checking/unchecking a box that enables/disables others (e.g. DetectorDiagnostic) and other cases (Run in LoadEventNexus) caused a crash (segfault).

comment:8 Changed 8 years ago by Dennis Mikkelson

Added ImageView to right-click menu for EventWorkspace

Added simple wrapper class EventWSImageView, and modified MantidUI and MantidDock to include ImageView in options for viewing EventWorkspaces. refs #5050

Changeset: 32e27356f647693c705622ee519a78331243ad41

comment:9 Changed 8 years ago by Dennis Mikkelson

Added ImageView to right-click menu for EventWorkspace

Added simple wrapper class EventWSImageView, and modified MantidUI and MantidDock to include ImageView in options for viewing EventWorkspaces. refs #5050

Changeset: 32e27356f647693c705622ee519a78331243ad41

comment:10 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:11 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

No crash seen on any platform. The commit from Dennis clearly belongs to different ticket.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​5896

Note: See TracTickets for help on using tickets.