Ticket #5544 (closed: fixed)
The results table should be read & write.
| Reported by: | Robert Whitley | Owned by: | Arturs Bekasovs |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Muon | Keywords: | |
| Cc: | anders.markvardsen@… | Blocked By: | #8774 |
| Blocking: | Tester: | Nick Draper |
Description
Currently the table is read-only. The muon scientists want the ability to change the values if they are wrong or aren't included.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:3 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:5 Changed 7 years ago by Nick Draper
Robert's old tickets returned to you for assessment.
Are they still valid, duplicates?
comment:6 Changed 7 years ago by Nick Draper
- Owner changed from Robert Whitley to Anders Markvardsen
Robert's old tickets returned to you for assessment.
Are they still valid, duplicates?
comment:8 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:9 Changed 7 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Arturs Bekasovs
comment:11 Changed 7 years ago by Arturs Bekasovs
- Milestone changed from Release 3.0 to Backlog
With a current state of affairs I can't make columns of ITableWorkspace editable, because originally Matrix and Table workspaces were intended to be non-write only. Hence getReadOnly() method is hard-coded to return true.
Release is too soon to make such a deep changes, so leaving in back-log for now and will return to it in the next iteration.
comment:12 Changed 7 years ago by Arturs Bekasovs
- Component changed from Framework to Muon
- Summary changed from MUON: The results table should be read & write. to The results table should be read & write.
comment:13 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:16 Changed 7 years ago by Arturs Bekasovs
- Status changed from assigned to inprogress
Refs #5544. Make it possible to update column read-only status
Changeset: 3189d82b82593302fb2d21593fdd9c85e3ab55a7
comment:17 Changed 7 years ago by Arturs Bekasovs
Refs #5544. Create results table as non-read-only.
Changeset: a5391614ff1a3441941aab475f7b12f6d209e4ff
comment:18 Changed 7 years ago by Arturs Bekasovs
Tester:
Please review the changes made to Column class. Verify that they should not change the default behaviour of the column readability - all the columns should be created read-only by default. It's just now it's possible to change that.
- Create a ResultsTable using MuonAnalysis. (Load -> Fit -> Create Table)
- Change a few values. Make sure you change at least one of each:
- Log value (e.g. run_number)
- Fitted parameter value (e.g. A0)
- Fitted parameter error value (e.g. A0Err)
- Close the table.
- Open the table again and make sure your changes values are still there.
- Try to plot the table - the plot should use the changed values.
comment:19 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:20 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:21 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/5544_muon_result_table_not_read_only'
Full changeset: f3a02744b1d5e69b12607c7324fdab4409bcbe26
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6390
Moved at the end of release 2.2