Ticket #5791 (closed: fixed)
Implement Lorentz correction in ConvertToMD algorithm
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.3 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Karl Palmen |
Description
Lorentz corrections are often used for analysis of elastic diffraction experiment results.
They are currently implemented in ConvertToDiffraction workspace algorithm but need to be available in more general case of ConvertToMD algorithm.
Change History
comment:2 Changed 8 years ago by Alex Buts
refs #5791 Implemented Lorentz corrections calculations.
Checks still needed.
Changeset: 814fe9badcc795dce0a5e6b6fdae0aa75ee43753
comment:3 Changed 8 years ago by Alex Buts
refs #5791 Fixing unit tests
Changeset: 68686ea9811d4737a34058bfce014de874e5bc4a
comment:4 Changed 8 years ago by Alex Buts
refs #5791 And test for MDTransfQ3D and Lorentz corrections
Changeset: 5da9633a978f90d7159b5a89c72281c55c3a2d3b
comment:5 Changed 8 years ago by Alex Buts
Technically works.
At the moment do not have way to check if the scientific results obtained are correct. May be just run it against ConvertToDiffraction workspace but this looks too much work for very small gain.
The wider question is the dimensions of the correction. The correction in fact is in A-4
which can cause unexpected problems. Though this can be partially addressed through multiplying the whole resulting workspace by the Bravais cell volume (why not to do this in one go, while applying the correction), the remaining [Wavelengs unit] is related to the spectral density per wavelength. Do not think it is easy to correct by this value having the target workspace only.
I think, the experimental scientist who uses this correction should have careful look.
comment:6 Changed 8 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 8 years ago by Alex Buts
refs #5791 Implemented Lorentz corrections calculations.
Checks still needed.
Changeset: 814fe9badcc795dce0a5e6b6fdae0aa75ee43753
comment:8 Changed 8 years ago by Alex Buts
refs #5791 Fixing unit tests
Changeset: 68686ea9811d4737a34058bfce014de874e5bc4a
comment:9 Changed 8 years ago by Alex Buts
refs #5791 And test for MDTransfQ3D and Lorentz corrections
Changeset: 5da9633a978f90d7159b5a89c72281c55c3a2d3b
comment:10 Changed 8 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:11 Changed 8 years ago by Karl Palmen
The ConvertToMD dialog box has a tick box for Lorentz correction.
comment:12 Changed 8 years ago by Karl Palmen
- Status changed from verifying to closed
Passed, but needs to be tested by a scientist who knows about this to verify results are correct.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 6637
