Show error in fitting tab

[Anders Markvardsen]

Request from Steve Cottrell.

After a fit display the error in brackets

Type LinearBackground

A0 9.213 (0.040)

A1 7.123 (0.080)

Steve e.g. look at the errors when e.g. fit several exponential, where large errors can indicate strong correlation. He would prefer to have this in the fitting tab rather than (remembering to) they are in table parameter workspace, and he things in particular inexperience users of Mantid would benifit from this also.

There should be an option in preferences to turn in on or off. I am not sure what the best default value for this should be.

Regardless of this choice when this feature has been implemented the Fitting tab in the muon interface will have this feature set to on.

[Anders Markvardsen]

Speaking to Steve Cottrell, Francis Pratt also requested this.

One problem is that while collecting data you may repeatedly load and fit a run until a particular statistical accuracy has been reached. It's much simpler to see the result if the error is alongside the parameter value.

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Arturs Bekasovs]

Not entirely sure how to approach that one. Will not have time in this release.

[Nick Draper]

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

[Arturs Bekasovs]

Refs #6616. Specialized property manager for parameters

It is currently a regular QtDoublePropertyManager, so nothing the fit browser should still work correctly. It gives me a way of overriding the manager for parameter properties only, leaving other double properties alone.

Changeset: 62ba1c1f5927de9c80814c0d80b58f5a013d1ef8

[Arturs Bekasovs]

Refs #6616. Specialized version of property manager for parameters

Changeset: a3210c09aae6ff8ff3af986fb2137b26961fb7ef

[Arturs Bekasovs]

Refs #6616. Implement error setting and proper displaying

Still a few things to do, but the basic functionality works perfectly

Changeset: 3db8431ca97cbbf6701a57bae94b290d5dd1f844

[Arturs Bekasovs]

Refs #6616. Specialized on-change function for parameters

Changeset: 79724a9dc889cbc5aaea536d2d37824e9bbfbbc3

[Arturs Bekasovs]

Refs #6616. Clear parameter error when the value get edited

Changeset: 0f65ab6b3dc5f380039dcb932a415a60f3595473

[Arturs Bekasovs]

Refs #6616. Make error setting to update the parameter display

Remove some unnecessary constness as well.

Changeset: ab078bfe62e013ab5522358c8e3af9974210f086

[Arturs Bekasovs]

Refs #6616. Set error values only when actual fit was done

Changeset: 41b954d8c8fff40b8b2114c8f821ceb9394577b7

[Arturs Bekasovs]

Refs #6616. Remove constness from error map

Changeset: 2bbe16352268370ebd140c4e014b25ab9498450a

[Arturs Bekasovs]

Refs #6616. Make it possible to turn error display on and off

Changeset: da3297051611d6930f8c8dd4670e873ee9f94d98

[Arturs Bekasovs]

Refs #6616. Add the new option to the Muon fit browser

Changeset: 87c68195d380c7951c981bbc2f16e839d818c8b0

[Arturs Bekasovs]

Refs #6616. Clear errors when doing undoFit

Plus some code refactoring to avoid repeating myself

Changeset: 6eaa99ee08ab68715b8b673dcc16c2344e244385

[Arturs Bekasovs]

Refs #6616. Attempt to fix broken builds.

• Missing DLLExport for windows
• Calling templated constructor

Changeset: 44cd3eb494595ea2b3ae10dd9d108cc91a24b622

[Arturs Bekasovs]

Tester:

New option and default value

A new option was added to the Fit Function browser, called "Show Parameter Errors". Verify that it was indeed added to both general Fit Browser and Muon one ( MuonAnalysis -> Data Analysis).

Before changing the value, verify that the default value is as expected. It should be set to false (for now, at least) in general fit browser and to true in Muon fit browser.

The value should be save-able. Change value, re-start Mantid and make sure it stays the same. Check that for both fit browsers.

Disabled behaviour

When option is disabled, fit browser should behave as usual. Try to fit a data set to a few fit functions, change a few options, use Undo fit etc. While doing that, make sure fit browser is functional and that parameter fields have their values displayed only.

Enabled behaviour

Enable the option. Now whenever you complete a fit, parameter errors should be shown next to parameter values. Errors should be updated when repeating fits.

Verify that error values are correct by inspecting the *_Parameters workspace created during the fit.

If should still be possible to edit the value. When the value is edited, the error should disappear. Doing another fit should show it again.

All the errors should disappear when Undo fit is done.

Disabling error showing should make all errors disappear. Re-enabling it shows errors again, but only those which where set.

[Arturs Bekasovs]

Refs #6616. Minor improvements

Changeset: 0fb68013861a3f6ce5ddf048b046bd2870885267

[Arturs Bekasovs]

Refs #6616. Better error formatting

Changeset: a012a0bf10eb3d12e9f0f3b26d711f3f82f2ff9c

[Arturs Bekasovs]

Refs #6616. Add missing include for fabs

Changeset: 20e48a950b43842de32e49593109868078b2d87c

[Roman Tolchenov]

A couple of suggestions:

1. Clicking on the parameter value starts an editor. When the editor loses focus the error always disappear regardless of whether the value changes or not. I suggest keeping the error visible if the value doesn't change.
2. The parameter tooltips should say that the number in brackets is the fitting error.

[Arturs Bekasovs]

Refs #6616. Clear error only when the parameter was really changed

Changeset: 78e2469bc3db832ed9b466640991e211b65f9d8a

[Arturs Bekasovs]

Refs #6616. Move param descr. handling to parameter manager

This will allow me to update it more easily and when it's needed

Changeset: 8da86b364605587cc3c7ee2da3c337c640c6164d

[Arturs Bekasovs]

Refs #6616. Add error description to the tooltip, when one is set

Changeset: 7ee4e52798df73a2295f045e455b330a29f4e5ae

[Roman Tolchenov]

Working as expected

[Roman Tolchenov]

Merge remote-tracking branch 'origin/feature/6616_muon_error_in_fit_browser'

Full changeset: ​cddcde2885e56aed7bd60db3fedd8a78b5d35855

[Stuart Campbell]

This ticket has been transferred to github issue ​7462