Ticket #6622 (closed: fixed)
PlotPeakByLogValue should optionally output calculated spectra like Fit does
| Reported by: | Roman Tolchenov | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Roman Tolchenov |
Description
Change History
comment:3 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:4 Changed 7 years ago by Samuel Jackson
- Owner changed from Roman Tolchenov to Samuel Jackson
comment:7 Changed 7 years ago by Samuel Jackson
Refs #6622 Add option to output workspaces created by Fit.
Couple of things to note:
- The CreateOutput option defaults to false so the algorithm won't
suddenly start churning out lots of workspaces.
- As the algorithm outputs all the parameters to a single table,
regardless of the number of input workspaces, I've chosen to output all the output workspaces to a single group per type.
- Output workspaces are numbered according to the spectrum in the input workspace
used.
Changeset: e4e193ce781f2ca4d41004d38c032c2d6af1badb
comment:8 Changed 7 years ago by Samuel Jackson
Refs #6622 Add unit tests for new option.
Changeset: 05aeeac841e03f8725d6b8baae497e9a2cc78708
comment:11 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
- Tester set to Roman Tolchenov
To Tester
The PlotPeakByLogValue algorithm has a new option called "CreateOutput". This is passed as parameter to the Fit option of the same name. The algorithm will now create the output from fit for each spectrum and each workspace supplied as input to PlotPeak. These workspaces are then grouped according to type (NormalisedCovarianceMatrix, Parameters, and Workspace).
Check that the option works with different numbers of files, different ranges etc. Check that the option is off by default and no output is generated.
comment:13 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:14 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #6622 Add option to sequential fitting dialog
Changeset: 111674bcb68c4defb571008753ef7071755d7489
comment:15 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Samuel Jackson
To Tester
As above, but I've also added the option to the sequential fitting dialog on Roman's suggestion, so check that works too.
comment:18 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
Group names are wrong: the parameters go to _Workspaces group and the fit workspaces go to _Parameters.
comment:19 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #6622 Put workspaces in correct groups.
Changeset: 6c3ada843dabfdcc127d7f9b26c8bc87fa0962fb
comment:20 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
Silly mistake. I just swapped the variable names and check that fixed it.
comment:21 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to closed
Merge remote-tracking branch 'origin/feature/6622_plotpeakbylogvalue_fit_output'
Full changeset: d2d91f0026eb42fd940b6554e49622bdcf988b0d
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7468
Moved to r2.6 at the end of r2.5