Ticket #6807 (closed: fixed)
Incorporate checking of the ILiveListener::supportsHistory() method into StartLiveData
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description (last modified by Russell Taylor) (diff)
In the case that it's false, it should not be possible to ask for a start time other than 'now'. The same should be true of listeners that return histograms rather than events (actually, in that case I guess you're essentially always starting from the beginning of the run).
I should also think about how to deal with a start of run request. It's not explicitly in the interface and for the SNS listener a 'magic number' is being passed as the start time. If it's going to remain like that, at least that needs to be well documented.
Change History
comment:3 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after the code freeze for R2.6
comment:5 Changed 7 years ago by Russell Taylor
- Description modified (diff)
- Milestone changed from Release 3.0 to Release 3.1
comment:8 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state
comment:9 Changed 6 years ago by Russell Taylor
- Status changed from assigned to inprogress
Re #6807. Add log warning on unfulfilled request for historical data.
If an event-based live listener does not support historical data, then tell the user that they're only going to be getting data from the algorithm launch time onwards.
Changeset: 5166bdac09640c5916a05678dab9e1e1fb7d50ed
comment:10 Changed 6 years ago by Russell Taylor
Re #6807. Use non-stream logger for fixed string.
Also set the start time to zero rather than the current time, for consistency with what's done above. The end result will be the same.
Changeset: bb8b39efd8cada4b13269c1e4159b7e403339c48
comment:11 Changed 6 years ago by Russell Taylor
Re #6807. Make comments more general.
The previous comments don't belong in this general class as they were talking about very specific SNS/ADARA/SMS things.
Changeset: 26ed0b69ed1fb9398fe3588f716b5150d6821a89
comment:12 Changed 6 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
This is really just the addition of a log message, so is easy to test.
comment:13 Changed 6 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
comment:14 Changed 6 years ago by Russell Taylor
- Status changed from reopened to inprogress
Re #6807. Correct the supportsHistory value on the SNS listener.
Changeset: 78048c5abd8b3228e6cc9a157af9c252e62859e8
comment:15 Changed 6 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Now that the SNS listener supportsHistory message gives the correct answer, you don't see this log message when running with SNS instruments.
comment:16 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:17 Changed 6 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/6807_livedata_supportshistory_check'
Full changeset: d2e193cbe0d52afd29b2f7a692355d2749f583e4
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7653
Moved to r2.6 at the end of r2.5