Ticket #6830 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Incoming logs are not combined when using 'Append' option of StartLiveData

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.2
Component: Framework Keywords: LiveData
Cc: rgmiller@… Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Russell Taylor) (diff)

The AppendSpectra algorithm, which is called in LoadLiveData::appendChunk to effect the workspace combination does not handle adding the logs from the new chunk/workspace. In general, this algorithm probably shouldn't add them but in this case it should.

The same kind of thing probably applies to the 'Replace' option as well, though really I suppose it comes down to how the concrete listener is doing the logs (e.g. whether it re-broadcasts them every time).

This ticket has a fairly low priority as by far the most common combination option will be 'Add'.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:4 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:5 Changed 7 years ago by Russell Taylor

  • Milestone changed from Release 3.0 to Backlog

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:7 Changed 6 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.2

comment:8 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #6830. Add option to combine logs in AppendSpectra.

When using this with live data, we want to be able to merge the logs from the two parts.

Changeset: 44dadba90f7be2575892010ded87bceb2fb1f74f

comment:9 Changed 6 years ago by Russell Taylor

Re #6830. Combine logs when appending in a live data run.

Changeset: 6c5fcdc1310e12d8564b9d21b172f23b3b1b21c6

comment:10 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

To test: Start up a live session and watch the logs accumulate. No more confusion on that front when people choose the option by mistake (because I doubt anyone is likely to choose it on purpose)!

comment:11 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:12 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/6830_combine_logs_option_on_appendspectra'

Full changeset: 8d96d184b22f0c6c7778543da3772084ff7be8ad

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7676

Note: See TracTickets for help on using tickets.