Ticket #7178 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[Muon] Temperature and field home display

Reported by: Anders Markvardsen Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.1
Component: MantidPlot Keywords:
Cc: francis.pratt@… Blocked By:
Blocking: #7179 Tester: Peter Parker

Description (last modified by Anders Markvardsen) (diff)

In the home panel in 'Run information' at the bottom display also the value recorded in the nexus field and temperature entries, if these are available in the nexus file.

In the nexus file these should be available from

run\sample\temperature run\sample\magnetic_field

As a first step to complete this ticket check if this information gets loaded up loading muon nexus files. If not have this done, and update the wiki http://www.mantidproject.org/Run#ISIS_Muon_data accordingly.

Then in MuonAnalysis use code like:

const Run& runDetails = matrix_workspace->run(); std::string runNumber = runDetails.getProperty("run_number")->value();

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Blocking 7179 added

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:3 Changed 7 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Arturs Bekasovs
  • Description modified (diff)

comment:4 Changed 7 years ago by Arturs Bekasovs

  • Milestone changed from Backlog to Release 3.1

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Summary changed from MUON: temperature and field home display to [Muon] temperature and field home display

comment:6 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

Refs #7178. Add a test for existing log properties.

Though http://www.mantidproject.org/Run#ISIS_Muon_data does have a list of run properties read from the Muon files, it wasn't checked in any of tests before.

Changeset: 8f75f52a241e91bf64430658ca3005389d8b41a3

comment:7 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Update test to check for new properties.

Changeset: 5f1f117c7014df8024bc8f1f5a9728160031be46

comment:8 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Improve test robustness against type mismatch.

Changeset: d82790a16426706d51d1ed3a5abc4d41abb6baf9

comment:9 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Make names of new parameters better.

Changeset: a9f273ec504aa33d5456fcc80bd74476adefe72f

comment:10 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Add code to read new properties from Nexus file.

Changeset: 9427b9c6308f8922ac11461dcc207d11b7b00c97

comment:11 Changed 7 years ago by Arturs Bekasovs

comment:12 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Do a minor refactoring.

Instead of going through a huge pain of calculating average of time series manually (from a string!) we can just use an appropriate method.

Changeset: a9db6983220f2a5277de97f5a82bf0ec305e33ae

comment:13 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Change property not found/set messages.

It is not an error when expected log is not found or set.

Changeset: 3150a53306075396c0281b8f6abf893e34e5e9d1

comment:14 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Use ostringstream to build info string.

Concatenating strings is inefficient and tedious.

Changeset: efda49d4afdedd8241fbc85d7d6ca134cbc530de

comment:15 Changed 7 years ago by Arturs Bekasovs

Refs #7178. Add code to display new properties.

Changeset: 5c46307b3b8f85c5e25220ac2a9c3faf38486e89

comment:16 Changed 7 years ago by Arturs Bekasovs

Tester:

All the necessary files are in AutoTestData directory.

Firstly, check that the code for loading temperature and magnetic field properties is sensible and that unit tests cover that functionality.

Then load MUSR00015189.nxs file and find sample_temp and sample_magn_field in the list of log values. To be 100% sure that the values are right, you can use hdfview application to inspect the file.

Check that new properties are displayed correctly in the run info box on the Home tab of Muon Analysis, again using MUSR00015189.nxs. Make sure values are correct.

Check that the situation when properties do not exist in the file is handled property. You can use argus0026287.nxs for that.

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:17 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:18 Changed 7 years ago by Arturs Bekasovs

  • Summary changed from [Muon] temperature and field home display to [Muon] Temperature and field home display

comment:19 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:20 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7178_muon_temp_and_field_logs'

Full changeset: f88d1d0738aefbdb02e9f49afd352c170ecf3526

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8024

Note: See TracTickets for help on using tickets.