Ticket #7551 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

State of Python Button on Main GUI not changing when window is closed manually

Reported by: Keith Brown Owned by: Federico M Pouzols
Priority: trivial Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Dan Nixon

Description

The "open python script editor" button in the main gui has a problem.

when you click it it opens the editor as your would expect and changes it's appearance to being "pressed"

If you then close the editor by clicking the X in the corner the python button doesn't change back to it's normal "unpressed" status.

If you press it again it changes back to "unpressed" and calls the editor again, and will stay that way if the editor is closed by clicking the X.

pressing the button in either state while the editor is open, closes the editor and changes the button to the other state.

Observed in Windows and Ubuntu, not checked in Mac or Red Hat.

Ideally the button should only be "pressed" when the editor is open, and "unpressed" when the editor is not open.

Change History

comment:1 Changed 7 years ago by Keith Brown

  • type changed from enhancement to defect

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

(Committed under wrong ticket number. Sorry.)

Last edited 7 years ago by Russell Taylor (previous) (diff)

comment:3 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to new

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:5 Changed 6 years ago by Federico M Pouzols

  • Owner set to Federico M Pouzols

comment:6 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

update python script button status when window closed/hidden, re #7551

Changeset: 3dda5555727b6f752b2395524b4f8efb77ffb28b

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

The status of the "script window" button in the tool bar is now in sync with the script window. Suggested steps to test:

  • show and hide the script window using the toolbar button or its shortcut (F3). When the window is visible the button is on/pressed, when the window is hidden the button is off/released. This should work well, as it used to.
  • try to close (hide) the script window by manually closing it (clicking on the X or similar that your window manager provides). The toolbar button should be released when you hide the window. Then, if you click on it (or press F3) the script window should show up again.

comment:8 Changed 6 years ago by Federico M Pouzols

  • Milestone changed from Backlog to Release 3.4

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/7551_state_of_python_button_toolbar_not_changing_when_window_closed_manually'

Full changeset: e4af9bb942db266e3deddff17e3d431b2495d483

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8396

Note: See TracTickets for help on using tickets.