Ticket #7692 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add comments to the TestHelpers headers stating where they can and can't be used

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

This is to try and help avoid illegal dependencies (e.g. using WorkspaceCreationHelper in API when it depends on DataObjects).

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Russell Taylor

Re #7692. Add comments stating where helpers can & can't be used.

The test helpers should not be used in a way that breaks our package dependency hierarchy, but this has been happening on occasion. These comments give guidance on that and will hopefully be spotted when someone is about to do something they shouldn't!

Changeset: d90ff8c74e10710f2648a2c49a57cfdb27902d17

comment:3 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch is feature/7692_testhelpers_guidance

Apart from removing a few unused headers in one file, this is just adding comments so is pretty simple to test!

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7692_testhelpers_guidance'

comment:6 Changed 7 years ago by Michael Reuter

This looks good to me. Nice warnings!

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8537

Note: See TracTickets for help on using tickets.