Ticket #8104 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

QueryMDWorkspace on LineViewer cuts

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: blocker Milestone: Release 3.0
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

The SliceViewer LineViewer exports new MDWorkspace (MDHistoWorkspaces), which can be properly plotted with the Plot MD option in Mantid Plot. However, if you inspect this workspace data using QueryMDWorkspace, the coordinates printed are not in terms of the original workspace coordinates. What this esentially means, is that there is no way to export the X,Y,E data from these workspaces. This is an urgent requirement on the WISH instrument.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Owen Arnold

refs #8104. This should now fix the defect.

Test demonstrates this working.

Changeset: 3bcf12ad55b7e082e80688e10f359170c2c6b1bf

comment:3 Changed 7 years ago by Owen Arnold

Tester:

Run the following script in an old version of Mantid

CreateMDWorkspace(Dimensions='2',EventType='MDEvent',Extents='-10,10,-10,10',Names='Q_lab_x,Q_lab_y',Units='A,B',OutputWorkspace='test')
FakeMDEventData(InputWorkspace='test',UniformParams='1000',PeakParams='100000,0,0,1')
  • Now open the 'test' workspace in the SliceViewer
  • Use the LineViewer to draw a like from the bottom lhs of the screen diagonally to the top rhs.
  • Look at the preview plot and notice the range for the x-axis scale Hit 'Apply' to create an output 1D workspace
  • run QueryMDWorkspace on the line MDWorkspace you just generated. Notice that the X values are not the same as were generated on the plot, and the y values are missing.

Now repeat all of the above on your local build after git test start. You'll find that the X and Y values are the same (as you would expect for a rotation of this kind). The X range matches the scale in the preview plot region of the LineViewer.

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This looks fine. I have one minor quibble. In the unit test, one of the checks says that there are six columns expected. I think that it's only five. This should be corrected to prevent any misleading messages should the test fail there.

comment:7 Changed 7 years ago by Owen Arnold

  • Status changed from reopened to inprogress

refs #8104. Correct error message.

Changeset: 85a72aa7aeac70fc3f8a42380a3b46e8528f0ccf

comment:8 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

Minor correction suggested has been made.

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:10 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8104_query_mdworkspace'

Full changeset: f89701ab2bc61d9e0c8d691328b181855a61488c

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8949

Note: See TracTickets for help on using tickets.