Ticket #8315 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Excess workspace group when loading summed workspaces

Reported by: Arturs Bekasovs Owned by: Peter Parker
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Arturs Bekasovs

Description 

# Clear ADS
mtd.clear()

# Load 2 summed workspaces
ws = Load(Filename='MUSR15190+15191')

# ADS:
# * MUSR00015190_MUSR00015191 - shouldn't be here
#   - MUSR00015190_MUSR00015191_1
#   - MUSR00015190_MUSR00015191_2
# * ws
#   - MUSR00015190_MUSR00015191_1
#   - MUSR00015190_MUSR00015191_2

This works when summing using '-' as well. When trying to delete excess group I get this: 

DeleteWorkspace('MUSR00015190_MUSR00015191')

# ADS:
# * MUSR00015190_MUSR00015191 - empty group

Change History

comment:1 Changed 7 years ago by Peter Parker

  • Owner changed from Anyone to Peter Parker

I'd like to take a look at this, if no one minds. I implemented the original MultiFileLoading code and feel confident I'll have enough time to fix this bug before the release of 3.1.

It may be a problem I can solve from just within the MultiFileLoading code, or it may have to do with underlying changes to WorkspaceGroups.

comment:2 Changed 7 years ago by Peter Parker

  • Status changed from new to inprogress

Refs #8315 - Simplify ADS cleanup after each test.

Replaced multiple calls to ADS.remove() with a single tearDown fixture.

Changeset: 999b42ab0fcdafdb49ddb630bd041b013a34d3e3

comment:3 Changed 7 years ago by Peter Parker

Refs #8315 - Clean up after multifile loading.

  • Remove temp workspace at end of summing.
  • Ensure output of load is in the workspace it's supposed to be.

Changeset: 9661188be432b2e18e41a76d71c51b4089621610

comment:4 Changed 7 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester

Go to View -> Preferences -> Mantid -> Options and make sure that "Show Invisible Workspaces" is checked. Run the following: 

# Clear ADS
mtd.clear()

# Load 2 summed workspaces
ws = Load(Filename='MUSR15190+15191')

Make sure that only three workspaces exist as a result of the load: MUSR00015190_MUSR00015191_1, MUSR00015190_MUSR00015191_2 and their WorkspaceGroup parent ws.

Make sure the changes are adequate and are properly covered by the unit test.

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verify to verifying
  • Tester set to Arturs Bekasovs

comment:6 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8315_fix_excess_group_when_loading_summed_ws'

Full changeset: ​cabae660d2cddfdfae4f7907e62eb81915940f10

comment:7 Changed 7 years ago by Arturs Bekasovs

Code changes are sensible. Unit test does seem to cover the case. The script specified has an expected effect.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9160

Note: See TracTickets for help on using tickets.