Ticket #8318 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Trying to save QtiPlot entities to Nexus file causes exception

Reported by: Arturs Bekasovs Owned by: Federico M Pouzols
Priority: minor Milestone: Release 3.4
Component: GUI Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Raquel Alvarez Banos

Description

When you try to save Table, Matrix, Graph etc. to a Nexus file you get an exception: Invalid input workspace for SaveNexus. Saving these things using SaveNexus is obviously impossible, however the File -> Save -> Nexus menu item is not disabled in that case.

On contrary, File -> Save ASCII is disabled when current object couldn't be saved to ASCII, e.g. when it's a Graph.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:3 Changed 6 years ago by Federico M Pouzols

  • Status changed from assigned to verify
  • Owner changed from Anyone to Federico M Pouzols
  • Resolution set to worksforme
  • Milestone changed from Backlog to Release 3.4

I think this is not an issue anymore. I cannot reproduce it.

For Tables, Matrices, and Graphs: both the Save button in the workspaces window and the File->Save->Nexus action are disabled. The Save action is enabled only when you a workspace selected, and it applies to the workspace. Recent changes to this have been made in #1109, and possibly other tickets.

Another related (or duplicated) ticket: #8287

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to reopened
  • Resolution worksforme deleted

The option in File > Save is still there for me, both clicking that and using Ctrl-S allow me to try and save a matrix and always gives an exception.

Tested on the latest master.

comment:6 Changed 6 years ago by Federico M Pouzols

  • Status changed from reopened to inprogress

I see, it still happens if you start from an empty environment. Once you have loaded a workspace at least and selected/deselected workspaces the problem seems to go away.

This also applies to all the other objects that you can create with New->, like note, 3D surface plot, etc.

So the issue would become something like this:

  • Starting from an empty environment, if you create a table/matrix/graph/note, etc. the Save->Nexus action is active and you'll get an exception/crash if you try to use it for such objects.

comment:7 Changed 6 years ago by Federico Montesino Pouzols

prevent Save Nexus from being used on qti entities re #8318

Changeset: b9a0d03a887a2482e8b5b235606b37451d774944

comment:8 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

I also updated "save project as" so that it is disabled at the beginning and becomes enabled as soon as the project is modified/something is done, or a project is loaded. This was for consistency with "save project" which is disabled at the beginning when you start in an empty environment.

Related to this, there are details in the behavior of the project save actions that I don't understand well, or they may not be well adjusted. For example, Save->Project is disabled if the project hasn't been modified since the last save. But if you double-click on the project (project explorer) it is somehow marked as modified and Save->Project is enabled.

Anyway, I think this exception/crash is now sorted out. To test:

  • check that you don't get the crash, with empty and non-empty environments.

comment:9 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester changed from Dan Nixon to Raquel Alvarez Banos

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Seems that a checkbuild is needed:

ERROR: Branch 'feature/8318_qtiplot_entities_save_to_nexus_causes_exception_and_should_not_be_possible' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.

comment:11 Changed 6 years ago by Federico M Pouzols

Oops, it should work now...

comment:12 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8318_qtiplot_entities_save_to_nexus_causes_exception_and_should_not_be_possible'

Full changeset: c31ed647dd3d186dc0e547337409ac587273844b

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9163

Note: See TracTickets for help on using tickets.