Ticket #8362 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Clear memory leaks in the DataObjects package

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.2
Component: Framework Keywords: Maintenance
Cc: Blocked By: #8358
Blocking: Tester: Owen Arnold

Description

The SNS Jenkins has a ​valgrind job which checks the DataObjects code in so far as it is exercised by the unit tests.

Using this job and/or valgrind runs of your own, eliminate all the leaks/errors that result from code in the DataObjects package - i.e. under Framework/DataObjects/inc/MantidDataObjects or Framework/DataObjects/src.

Note that this should be done after leaks coming out of the test code have been addressed (#8358).

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Owner set to Russell Taylor
  • Milestone changed from Backlog to Release 3.2

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:3 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #8362. Add a suppressions file for the DataObjects tests.

Valgrind complains about an OpenMP call within the EventList test. Suppress this warning as we can't do much about it anyway, even if it is real.

Changeset: b8214ffbb8e772042a2f694afdc907c8f96d8821

comment:4 Changed 6 years ago by Russell Taylor

Re #8362. Fix potential memory leak, shown in test.

The list of objects that were at some point locked was not being deleted in the destructor.

Changeset: bc18afc17dcfeba9f063f0da787cb4f2adb75da2

comment:5 Changed 6 years ago by Russell Taylor

Re #8362. Fix what looks to be an unconsequential typo.

Changeset: aaae64cb0b1adf374112aa82758199208a94e953

comment:6 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

The ​Jenkins valgrind job shows no leaks now when running the DataObjectsTest executable (click into "Valgrind Results" to see this.

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8362_dataobjects_memory_leaks'

Full changeset: ​84c746fd099dd4867a4eb31d906dbd0cabbe3d3d

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9207

Note: See TracTickets for help on using tickets.