Context Navigation

← Previous Ticket
Next Ticket →

Ticket #8391 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IBayes] Replace erange Fortran code with Python

Reported by:	Samuel Jackson	Owned by:	Samuel Jackson
Priority:	major	Milestone:	Release 3.1
Component:	Indirect Inelastic	Keywords:
Cc:	spencer.howells@…	Blocked By:
Blocking:		Tester:	Roman Tolchenov

Description

Spencer has kindly provided a python implementation of the erange function used in IndirectBayes. Meaning one less f2py call.

Attachments

IndirectBayes.py (31.7 KB) - added by Samuel Jackson 7 years ago.: Updated version of the script

Change History

Changed 7 years ago by Samuel Jackson

Attachment IndirectBayes.py added

Updated version of the script

comment:1 Changed 7 years ago by Samuel Jackson

Status changed from new to inprogress

Refs #8391 Added python implementation of energy range function

Changeset: b675835654e420480ebeaae916ee980865568016

comment:2 Changed 7 years ago by Samuel Jackson

Refs #8391 Correcting function to pass system tests.

Changeset: 7e6fd151f57e4dfba6f149c05e402f41cb148903

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8391 Remove unused Fortran modules.

As the implementation in this ticket replaces them.

Changeset: 3890f85f841365bbbdc3f554eca4108354d54501

comment:4 Changed 7 years ago by Samuel Jackson

Status changed from inprogress to verify
Resolution set to fixed

To Tester

This function is shared between most of the Bayes programs (ResNorm, Stretch and Quasi). The system test should already be checking that we're getting the same output as before, but I would also suggest running through them with some example data. Instructions for running them can be found here:

http://www.mantidproject.org/Indirect:Indirect_Bayes

I've also removed the Fortran module erange, so make sure there are no references to it left in the project.

comment:5 Changed 7 years ago by Samuel Jackson

Milestone changed from Backlog to Release 3.1

comment:6 Changed 7 years ago by Samuel Jackson

Status changed from verify to reopened
Resolution fixed deleted

comment:7 Changed 7 years ago by Samuel Jackson

Status changed from reopened to inprogress

Refs #8391 Fix bin width counting.

Changeset: 5c5d04fec16c39f36b22f9c36bbbce32a92245cb

comment:8 Changed 7 years ago by Samuel Jackson

Refs #8391 Fix bin widths again.

Changeset: 53f6c8ae2caa0ce677acfdaaa5fc0fbcc5ef5763

comment:9 Changed 7 years ago by Samuel Jackson

Refs #8391 Fix bound overflow issue.

Changeset: 441f2e29230b3fcce38a115966f167c2e5e9f55d

comment:10 Changed 7 years ago by Samuel Jackson

Merge branch 'feature/8391_bayes_erange_python' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectBayes.py

Refs #8391

Changeset: c51367a183d01fec16632851b7f6b63c37830e4b

comment:11 Changed 7 years ago by Samuel Jackson

Refs #8391 Updated reference results.

Changeset: 5db0afc2814c25fea141360d38efedd8629cb42a

comment:12 Changed 7 years ago by Samuel Jackson

Status changed from inprogress to verify
Resolution set to fixed

To Tester

As above. Additionally, check the system tests are passing. Also be sure to run with the upper bound of the energy range set to the maximum possible and check that Mantid does not crash.