Ticket #8403 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

LoadFullprofResolution make OutputTableWorkspace optional

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 3.1
Component: Diffraction Keywords:
Cc: zhouw@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

In addition to Workspace make OutputTableWorkspace optional although at least one of these parameters most be specified

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Karl Palmen

Make it optional but only if Workspace is set re #8403

Also add unit test to test failure if neither OutputTableWorkspace nor Workspace is set. Also make use of optionality in another unit test.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9912519e7bcacf86519faa23a31c03afdf6be570

comment:3 Changed 7 years ago by Karl Palmen

Clean LoadFullprofResolutionTest.h re #8403

Changeset: 8fda4d3cf5644a5afaaafab92cc3a60ba6410a97

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test run the algorithm with both OutputTableWorkspace and Workspace set, with just one of them set and with neither set. It should fail with an error message if neither are set and should work as described in other cases.

Also check the the unit test is adequate.

comment:5 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:6 Changed 7 years ago by Wenduo Zhou

The optional tableworkspace works. And the unit test is sufficient.

comment:7 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8403_output_table_ws_optional'

Full changeset: 0872a66738ad828c02c126eb26a6abf18436041c

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9248

Note: See TracTickets for help on using tickets.