LoadFullprofResolution property to set correspondence between fullprof bank in workspace in group

[Anders Markvardsen]

Add optional property to enable the user to determine, which workspace in the group has the parameters of which bank in the .irf file.

When this property is specified do not enforce the restriction of #8402 that the number of workspaces in the group must equal the number of banks in the .irf file. It can be less, but compatible with the new property.

Apply the fullprof instrument parameters to the spectra specified

[Karl Palmen]

An example:

If banks is 2,3,1 and the new property is 1,2,4

then fullprof bank 2 is put into workspace groupname_1, bank 3 into groupname_2 and bank 1 into groupname_4.

[Karl Palmen]

Add code to set up workstation/bank correspondence re #8404

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 20fac33e325c2a59a5a3aea17f8057f0634cadf0

[Karl Palmen]

Fix function definition of new function re #8404

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ef11cfd6af93e30ce6f3c412a85ff79710b09b99

[Karl Palmen]

Complete code for desired effect re #8404

Passes unit test as is.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6098d0cd1a370cb68c843c1827847a317e383aa

[Karl Palmen]

Remove one size_t/int warning re #8404

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 86306253a8721a898b591c9420e1c4e57f665818

[Karl Palmen]

Extend unit test to test WorkspacesForBanks re #8404

In the course of this, I relaxed the #workspaces = #banks requirement whenever WorkspacesForBanks is used.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 760ed510d50f9c8f39ebc83da94b2fb217668c97

[Karl Palmen]

Attempt to fix compiler warning in getProfNumber re #8404

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f72f64bcbeb0f4d0b7de8afc6a66e1c7668437d9

[Karl Palmen]

To test check the unit tests are correct and adequate and the documentation is good.

Run with various combinations of the Banks and WorkspacesForBanks properties and verify the the parameters are transfered to the Ikeda-Carpenter functions of the instruments. You may use the files attached to #8402 for this.

[Wenduo Zhou]

Test was passed.

A suggestion is that it needs a better error message if 'WorkspacesForBanks' is set to integer that is not a valid BankID.

If Banks has fewer number of elements than those in 'WorkspaceForBanks', I am not sure what happens for the workspaces given but without bank number associated. For example, Banks = [1, 2, 3] and WorkspacesForBanks = [5, 4, 3, 2, 1], what happens with workspaces 1 and 2?

[Wenduo Zhou]

Merge remote-tracking branch 'origin/feature/8404_workspace_bank_correspondence'

Full changeset: ​4aa03616d71c2757b6c0ae17cff79c3087b3cb62

[Karl Palmen]

The answer to Wenduo's question in comment 13 is that workspaces 1 and 2 do not get any parameters set by the execution of the algorithm.

[Stuart Campbell]

This ticket has been transferred to github issue ​9249