Ticket #8442 (closed: fixed)
[ICAT] Mac loading fail
| Reported by: | Jay Rainey | Owned by: | Jay Rainey |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | ICAT, ICAT4 |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
When testing #8322 Russell noted:
- The bug is that if I try to load a .log file, it fails. More importantly, from that point on nothing works - loading a .raw file, initiating a new search... - they all just give an error.
Having tested this on Ubuntu, W7, and OSX (10.9) This issue only occurs on OSX.
Change History
comment:2 Changed 7 years ago by Jay Rainey
- Status changed from new to inprogress
Add context to SSLManager. Refs #8442.
Changeset: e3df04555eb2bb552adbe4a5ced06bb0f0898250
comment:3 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
Note: this ticket must be tested on OSX or RHEL and you must not have access to the archives.
To test
- Log into Mantid and perform a search.
- Select an investigation and download a datafile.
- Attempt to perform another search, logout/login, download etc. If they work (and it no longer throws errors) then the problem is fixed.
comment:4 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
I checked both on RHEL6 & OS X that the specific bug is fixed. However, there's a compiler warning on Windows about you use of Poco::SharedPtr - please address that.
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from reopened to inprogress
Use a raw pointer instead of shared. Refs #8442.
Changeset: 47ae20c8c6f80ad3e23536d311c533d098299338
comment:7 Changed 7 years ago by Jay Rainey
Include necessary header. Refs #8442.
Changeset: ff2a92fba55d5dbadfaff8aef097bb2e18ea928c
comment:8 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 7 years ago by Russell Taylor
I think that the inclusion of PrivateKeyPassphraseHandler.h should be sufficient to solve the warning issue, without having to change from smart to raw pointers which presumably leads to a leak.
comment:11 Changed 7 years ago by Jay Rainey
Use shared pointer to prevent leak. Refs #8442.
Changeset: e1849565072beace36439c88d10c5f581c530065
comment:12 Changed 7 years ago by Russell Taylor
One remaining problem: The commit in comment:7 appears to have gone directly to the develop branch as it isn't in the feature branch.
comment:13 Changed 7 years ago by Jay Rainey
Add missing header. Refs #8442.
Changeset: 333525c2244edab7cabd2f31255944ceb8259ecc
comment:14 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/feature/8442_icat_downloading_problem'
Full changeset: ab0262483980ace4a67c04b88df09000410c975b
comment:15 Changed 7 years ago by Jay Rainey
Include necessary header. Refs #8442.
Changeset: ff2a92fba55d5dbadfaff8aef097bb2e18ea928c
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9286
In fact, I observed this on Red Hat EL 6.