Fix keyboard shortcuts in the graph menu for plots

[Peter Parker]

To reproduce:

• Load some data and plot one or more of it's spectra.
• Click on the plot window so that the context-sensitive "Graph" menu appears.
• Try using the keyboard shortcuts for the various items in that menu.

I haven't tried them all, but "Add Layer" (Alt+L) and "Add Label" (Alt+T) do not work.

[Nick Draper]

bulk move to assigned at the into of the triage step

[Federico M Pouzols]

This menu may have changed over the last few months. In current versions I only see a couple of actions with keyboard shortcuts:

• Add/Remove &Curve, shotcut (Alt-C) doesn't work
• Add &Function, shortcut (Ctrl-Alt-F) works

Problem is: Alt-C conflicts with the main menu->&Catalog. So I think we should change the shortcut of add/remove curve to Ctrl-Alt-C and fix it.

[Federico M Pouzols]

Well, Ctrl-Alt-C is also used but in "Go to column" which should not be an issue.

[Federico Montesino Pouzols]

fix and redefine the add/remove curve action kb shortcut, re #8452

Changeset: 48c018405aea6d95080f3aa99b7fd1a7d831349b

[Federico M Pouzols]

Fixed as described in comment:2. The new keyboard shortcut for "Add/Remove Curve" is Ctrl-Alt-C.

To test, select your favorite workspaces, open spectrum plots and check that these two keyboard shortcuts work:

• Ctrl-Alt-F: should open the add function dialog
• Ctrl-Alt-C: should open the add/remove curve dialog

The two actions should also be visible in the context menu.

[Federico Montesino Pouzols]

fix also translated string, re #8452

Changeset: 2dfc8e11825d26958c9815f3ddfa2e7a6641bad8

[Dan Nixon]

There is still a conflict between Alt-I, this is both Add Image and the Interfaces menu.

[Federico Montesino Pouzols]

more general cleaning of main menu->graph shortcute, re #8452

Changeset: 3028dc7ae5d601a66d586f9d77b1ed9f6242145e

[Federico M Pouzols]

Aha, there were more. I had only paid attention to the context menu. I updated the graph menu shortcuts more in general, also for consistency with the Ctrl+Alt+? pattern that was used for most of them. Apparently there's no one else using Ctrl+Alt+? shortcuts (except the instrument viewer that is using Ctrl+Alt+E and +R) so this should prevent conflicts.

I also updated http://www.mantidproject.org/MantidPlot:_The_Graph_Menu with some actions that were missing and the current shortcuts.

The only Alt+? shortcuts remaining are add/remove/arrange Layer: Alt+L/R/A. For now I'd leave those as they are but there's the potential for conflict in the future.

Being picky, I do not really like the Ctrl+Alt+? shortcuts, as they may clash with many other things, including common desktop shortcuts. But well, it's the most backwards compatible option. 'Shift' would be an alternative, but Ctrl+Shift+M and Ctrl+Shift+A are being used in View->Workspaces/Algorithms.

The context menu only shows a couple of add/remove actions. That might be fine, but the plot toolbar does not seem very consistent to me. Why are "add function" and "add legend" shown but not "add curve", which is visible in the graph menu and the context menu? TimeStamp and Image are also missing from the tool bar. This may have been intentional but it looks like things just diverged over time. There are also inconsistencies in the "data" actions of this tool bar. I think I'm going to open a low priority maintenance ticket for the graph tool bar actions. Shortcuts in other entries of the main menu could also benefit from a bit of cleaning/harmonization work.

To test: please double check that all the shortcuts of the graph menu work (and also the subset of actions included in the graph context menu) and that they're correctly documented in http://www.mantidproject.org/MantidPlot:_The_Graph_Menu.

[Dan Nixon]

Merge remote-tracking branch 'origin/bugfix/8452_keyborad_shortcuts_plot_graph_menu'

Full changeset: ​4a1e1c4a04075912ceb4daf48911b7108b89fa8c

[Stuart Campbell]

This ticket has been transferred to github issue ​9296