Ticket #8454 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make it more clear that plotting has actually finished

Reported by: Peter Parker Owned by: Dan Nixon
Priority: trivial Milestone: Release 3.3
Component: GUI Keywords: student
Cc: Blocked By:
Blocking: Tester:

Description

Fit multiple peaks as per the example in Exercise 2 of the training course:

http://www.mantidproject.org/MBC_Exercise_Intelligent_Fitting

The progress bar in this case never gets past a few percent but still successfully completes the fit. We are shown the "Fit successful" message in the reports log, but one user has said that for those who don't have it open it may not be very clear that the fit has finished.

Could we make a "100%" call to the progress bar upon completion so that users have that extra visual clue as to what is going on?

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Nick Draper

  • Keywords student added

comment:3 Changed 6 years ago by Martyn Gigg

  • Milestone changed from Backlog to Release 3.3

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress
  • Owner set to Dan Nixon

comment:5 Changed 6 years ago by Dan Nixon

Added 100% progress indication to workflow Fit

Refs #8454

Changeset: 0c9efb9aa31a6c5837a5fc8639d1f8105b3a41a0

comment:6 Changed 6 years ago by Dan Nixon

Added a call to progress(1.0) at the end of the Fit algorithm (used by the Fit Function Qt widget). Now shows 100% progress when fitting is complete.

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 6 years ago by Peter Parker

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/bugfix/8454_fit_progress_reporting'

Full changeset: ​206267d6a195860c0e8ca555b77dd38a96b655d9

comment:9 Changed 6 years ago by Peter Parker

I was actually unable to go back and reproduce the original problem. When we saw the issue during the training course, the progress bar was still showing after the fit was completed. I tried it again using MantidPlot 3.1 and it seemed to go away without any problem.

However, I'll still pass this ticket and merge in changes, since it does no harm to see the "100%" message (even if it's just for a split second) at the end of fits.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9298

Note: See TracTickets for help on using tickets.