Ticket #8482 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Sliceviewer does not save to image any more

Reported by: Alex Buts Owned by: Federico M Pouzols
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: John Hill

Description

Tested on RHEL and Windows

If one looks at a workspace in the sliceviewer and tries to save it into an image (png), it behaves like it doing something but target image does not appear.

It used to work before.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Federico M Pouzols

  • Owner set to Federico M Pouzols

comment:3 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from assigned to inprogress

ensure .png extension so QPixmap save works, re #8482

Changeset: 80da92915b8b7c3727c48cf4c37008b9631bd60e

comment:4 Changed 6 years ago by Federico Montesino Pouzols

new helper function for .png extension, re #8482

Changeset: 51ee3a2df09a9685a9235a476654cbf1b6aaca98

comment:5 Changed 6 years ago by Federico Montesino Pouzols

fix doxygen param name, re #8482

Changeset: 34581caada4aed77cb534405a41b16f031723ecc

comment:6 Changed 6 years ago by Federico Montesino Pouzols

all fine in windoze, remove qdebugs, re #8482

Changeset: 759cd1c63c050359a203421d3a74b90832b1b0cc

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

What was happening is that you need to add the .png suffix, or the QPixmap method that is used to do the real saving won't write anything. I've fixed the code so that the prefix is added if the user doesn't add it.

To test:

Open the Slice Viewer for your favorite workspace(s), then do File->"Save to image file", giving any reasonable file name. Check that you get a file with that name and that the bitmap (png) looks like what you see in your Slice Viewer.

There are no tests for this and it doesn't look like the kind of thing that can be added as a unit test.

comment:8 Changed 6 years ago by Federico M Pouzols

  • Milestone changed from Backlog to Release 3.3

comment:9 Changed 6 years ago by John Hill

  • Status changed from verify to verifying
  • Tester set to John Hill

comment:10 Changed 6 years ago by John Hill

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8482_SliceViewer_doesnt_save_image'

Full changeset: ad4e442d34010824fdb0e0d690d6bf0729a91c42

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9326

Note: See TracTickets for help on using tickets.