Ticket #8490 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix unreleased use of POCO::XML document and nodelists in LiveData code

Reported by: Karl Palmen Owned by: Russell Taylor
Priority: major Milestone: Release 3.2
Component: Framework Keywords: maintenance
Cc: Blocked By:
Blocking: #10637 Tester: Jay Rainey

Description (last modified by Karl Palmen) (diff)

In the code of framework/LiveData I found two cases of POCO::XML document or nodelist objects being created, but not released. This could cause memory leakage. Fix by using AutPtr for the object.

The two are SNSLiveEventDataListener and ADARAPacketTest.

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Description modified (diff)

comment:2 Changed 7 years ago by Karl Palmen

  • Description modified (diff)

comment:3 Changed 7 years ago by Russell Taylor

  • Owner set to Russell Taylor
  • Milestone changed from Backlog to Release 3.2

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from assigned to inprogress

Re #8490. Use Poco::AutoPtr instead of manual release.

Changeset: ed335557b15db7f48fcbd5c761754feebe5bcf31

comment:6 Changed 7 years ago by Russell Taylor

Re #8490. Fix memory leak in test.

The Poco object being returned from parseMemory was not being released.

Changeset: a86c2189842d45914dd1994b1c82b320265d74b0

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

The two files mentioned in the description are now correctly using AutoPtr in all appropriate circumstances. Check by inspection.

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:9 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

I used grep in the master branch to see all cases of release and parseMemory. I then used it in this branch locally and performed a code inspection. All cases of release and parseMemory in framework/LiveData have been fixed.

comment:10 Changed 7 years ago by Jay Rainey

Merge remote-tracking branch 'origin/bugfix/8490_livedata_xml_autoptr'

Full changeset: ​098ca3bfc0891486e4e282402550bf68408e57a0

comment:11 Changed 6 years ago by Federico M Pouzols

  • Blocking 10637 added

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9334

Note: See TracTickets for help on using tickets.