FileValidator: The call to the lowercase function object does nothing

[Russell Taylor]

...because operator() consumes the string by value.

The solution is:

(a) Something in the FileValidator constructor like:

for (auto it = extensions.begin(); it != extensions.end(); ++it)
{
  m_extensions.insert( boost::to_lower_copy(*it) );
}

(b) Just remove the code because we seem to be doing fine without it.

[Nick Draper]

bulk move to assigned at the into of the triage step

[Dan Nixon]

Added lowercase conversion for extensions

And modified unit test accordingly Refs #8543

Changeset: ad6643cb669693ab9ac74495ec3b591464769dce

[Dan Nixon]

Removed unused lowercase transform

Refs #8543

Changeset: b0238ec32a77001d2265dad748504802ad72d4fd

[Dan Nixon]

Used first solution to ensure all extensions are converted to lowercase.

This caused unit tests to fail when they expected "RAW" and "raw" to be two distinct extensions, such tests have been modified to represent the intended functionality (i.e. expect the size of allowedValues() to be 1 instead of 2).

[Peter Parker]

Merge remote-tracking branch 'origin/bugfix/8543_filevalidator_lowercase_fix'

Full changeset: ​8e6d3987b9c115702d498dcfea41da35e06c0f5d

[Stuart Campbell]

This ticket has been transferred to github issue ​9387