Comparison between ISIS and SNS redduction

[Alex Buts]

Comparison between some aspects of ISIS Branch of DGSReduce (C++) developed by SNS and Python dgreduce currently used on ISIS inelastic instruments.

[Alex Buts]

refs #8557 Two questions to 2 suspicious places of code

Two places found after code review which look like wrong. Questions to code were placed after !!! mark

Changeset: c68cbf162532364e16fd28a1a6fb35d141e2d82e

[Alex Buts]

refs #8557 Mary Diag System test comparison

Changeset: 641d7d7f85d11508df9281712e1c8372850cdec7

[Alex Buts]

refs #8557 Draft document comparing ISIS current and SNS for ISIS

prospective reduction procedures.

Changeset: a928c6330b6757903111a491dd151750b1f413e5

[Alex Buts]

refs #8557 Nick contribution to the comparison document.

Changeset: 6c88f4bbd25a596542260b7d7db16fdbe0e3414a

[Alex Buts]

refs #8557 Editorial changes to document

Changeset: 8c3ffe155bbe461cfb6397277ef9c7dad80a27f3

[Alex Buts]

refs #8557 Toby's remarks

Changeset: d1147faa68b30397061790c080f4148ceee8f9d5

[Alex Buts]

refs #8557 Final minor remarks to the comparison document

Changeset: afa819c1376a98c10bfd2bbf136a4c6f429899d6

[Alex Buts]

There are almost no code changes in this ticket. Main work was in MantidDocuments on Master in ​https://github.com/mantidproject/documents/tree/master/Design/Diagrams/inelastic and the document is SNS_VS_ISIS_reduction.docx

There are two minor comments in Mantid code, branch 8557, which I believe should be merged to master and answered in another ticket which should follow from the discussion on things, outlined in the document.

[Alex Buts]

The main result of this ticket is the document referenced above used to facilitate discussion about the future of inelastic reduction in ISIS.

I have also started working on merging the reduction but have stopped it after receiving feedback from the group.

Despite that, small questions for a future to the code and a System test which shows that SNS diagnostics produces the same result as ISIS diagnostics for MAPS were done. I believe these are valuable additions to future work in this direction so the Mantid branch and the System tests branch should be merged to master after a code review.

There is clear interest in possibility to run foreign reduction (e.g. SNS reduction for ISIS instrument or v.v.) so these changes can be the base for a future work in this direction but the work itself would be under other tickets.

[Nick Draper]

ERROR: Branch 'feature/8557_SNSvsISIS' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments .

Contact Alex Buts on Alex.Buts@… (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/8557_SNSvsISIS and let you know when it passes testing on the buildservers so you can start testing.

[Alex Buts]

These minor changes were sitting on Develop for so long, that were removed from Develop on release and I've completely forgot about it.

[Alex Buts]

refs #8557 Modified convToEnergy to show SNS/ISIS differences clearly

There are no changes to how the code run, but it has been modified to allow clear separation between SNS and ISIS related workflows - these changes make the difference explicit and allow easily modify the code to run foreign reduction.

Changeset: d2257d14eb55e62564374515ca6753163ad7c28f

[Nick Draper]

passed by code review

[Nick Draper]

Merge remote-tracking branch 'origin/feature/8557_SNSvsISIS'

Full changeset: ​c10fb42cb46d0f1f812942387946f1106083ef33

[Stuart Campbell]

This ticket has been transferred to github issue ​9401