need to flag missing flood source file as an error

[Gesner Passos]

Richard reported:

I notice (at least for the Sept 2013 version on LOQ) that if the “flood source file” is not found it gets a red asterix on the data reduction tab, but this is not flagged as an error. It needs to be flagged up, as else the user does not get the expected results as specified in the user file.

[Nick Draper]

Bulk move to assigned at the introduction of the triage step

[Gesner Passos]

MaskFile to show the error

[Gesner Passos]

The script check8562.py seems to suggest that the problem is in the GUI that somehow passes valid flood input file to the reduction. Because, the reduction itself, does not run without a valid flood file as shown in the check8562.py.

[Gesner Passos]

It is necessary to surround the method around this patch to catch the exception generated. But, the patch shows where the error is.

[Peter Parker]

Refs #8562 - Do a check for valid flood files before reducing.

This is based on Gesner's patch, which only checks on the GUI side of things. It would be better to do this in the Python layer as well, but this will have to wait until a later date. I'm sitting on a large amount of code to do with User File parsing that will deal with file validation a lot better, and this will someday make it in as part of #9367, but we have so many other things to do that it's just not a priority at the moment.

Changeset: f17964e7d7e838f6fa01680e673631af7dc7e30c

[Peter Parker]

To test (ISIS only):

\\olympic\babylon5\Public\PGP\Test Data\8562 contains the files needed for testing. Add it to Mantid's Managed Directory list.

• Load up the ISIS SANS interface.

• Choose the LOQ instrument from the dropdown box.

• Load the loqmask.2.txt User File from the folder above. This references a non-existant flood file.

• Type 74044 into the Scattering Sample field and click "Load Data".

• Hit "1D Reduce" and you should see a popup box indicating the reduction was stopped.

• Load the loqmask.txt User File from the folder above. This references a flood file that DOES exist.

• Re-click "Load Data".

• Hit "1D Reduce" and the reduction should reach the end without any errors. (You will probably see some warnings. It is not the scope of this ticket to deal with them.)

[Jay Rainey]

Merge remote-tracking branch 'origin/feature/8562_flag_missing_source_file_before_reduction'

Full changeset: ​ff7108e12e015c639e3f95e3bce4cbaac86b190a

[Jay Rainey]

An appropriate error message is now displayed when necessary. Sensible code changes.

[Stuart Campbell]

This ticket has been transferred to github issue ​9406