Ticket #8568 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Pick tab detector sum is wrong in d-spacing

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.2
Component: GUI Keywords:
Cc: pascal.manuel@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

When a shape is drawn in the pick tab the mini-plot shows the sum over detectors. Summing doesn't take into account that the x-values can be different for different spectra.

Attachments

mkws.py​ (288 bytes) - added by Roman Tolchenov 7 years ago.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Milestone changed from Release 3.1 to Release 3.2

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #8568. Separate treatment of ragged workspaces.

Changeset: c69898e2426750846fa39ec38964678ebc491154

comment:4 Changed 7 years ago by Roman Tolchenov

Re #8568. Fixed storing and saving curves

Changeset: 909674b4dce326bde0217da5f345194fea1ef350

comment:5 Changed 7 years ago by Roman Tolchenov

Re #8568. Update the plot caption

Changeset: d20981b95d4415c5d6c794e2471c30cd84c1ea71

comment:6 Changed 7 years ago by Roman Tolchenov

Re #8568. Fixing a gcc warning

Changeset: c6562084875d5edda7819d8aae84e3d24bc82f55

comment:7 Changed 7 years ago by Roman Tolchenov

  • Cc pascal.manuel@… added
  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

I cannot see an easy way to test this directly. Examine the code, compare plots taken in d-spacing with and without the changes. Pascal should be able to confirm correctness of the plots.

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Looking at the code review, could the sumDetectors method not use the CommonBinsValidator rather than just check using the unit? It is possible to have ragged bins in TOF (although not that common).

Also would it be worth caching the result (and clearing the cached value whenever the workspace is updated).

Does the colour display of the detectors correctly handle ragged workspaces?

Comment on SumDetectorRagged is wrong (surely it does not assume x values are shared)

Changed 7 years ago by Roman Tolchenov

comment:10 Changed 7 years ago by Roman Tolchenov

To tester

I found a way to test.

  1. Run the attached script to create a ragged workspace. All 64 spectra contain the same Gaussian.
  2. Open the instrument view. Go to Pick tab.
  3. Draw a shape around some detectors. Change the shape's size and position to cover different detectors.
  4. If everything is working as expected the mini-plot should show a Gaussian centred at 0. The height of the peak can change but not the shape/width.

comment:11 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to inprogress

Re #8568. Use a validator to check for workspace raggedness

Changeset: 17c5fe0890dee8467db24a03f610a9291a8e3d57

comment:12 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

The detector colours seem to be correct for ragged workspaces.

comment:13 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester changed from Nick Draper to Vickie Lynch

comment:14 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8568_detector_sum_in_dspacing'

Full changeset: ​41bb9061d6a9f2b6b71223f524be3d4238d7d020

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9412

Note: See TracTickets for help on using tickets.