Add option to run ConvertToHistogram to LoadDaveGrp

[Martyn Gigg]

As above, but histogram output is optional.

[Martyn Gigg]

This enables the output to be integrated straight after loading.

[Samuel Jackson]

Refs #8594 Catch bad lexical cast.

The original code could cause an (effectively) infinite loop when a bad file format was used.

Changeset: 3efcb667c57c2e85f542e33ed9239c027a1c5f97

[Samuel Jackson]

Refs #8594 Convert output of LoadDaveGrp to histogram data.

Changeset: 0af1243562b22a95cd4ac7e6b56df375123941ed

[Samuel Jackson]

Refs #8594 Update unit test to match output.

Changeset: cb59b6c7fc009fcec78a57cb7b53e726f2218e00

[Samuel Jackson]

Refs #8594 Throw runtime error instead.

This is so that we can catch the error if setRethrows is set to true.

Changeset: 0bb372886e10ceeb161c6a48ac80b6954899e82e

[Samuel Jackson]

Testing file which will reproduce the error.

[Samuel Jackson]

To Test:

There are two things that need testing:

• Check that the output from LoadDaveGrp is now a histogram.
  • The supplied DMPC_295Kdyn_grp​ can be used to test this. Download and rename to DMPC_295Kdyn.grp​
• Check that the algorithm will no longer enter into an (effectively) infinite loop when parsing a bad file format.
  • Use the DMPC_295Kdyn_bad.txt​ to test this. I suggest you run the alg without the changes first to see the problem, then retest with changes and observe that the error is caught.

[Michael Reuter]

The ticket specified that making the DAVE grouped ASCII files a histogram was to be an option, not the default behavior. This changes the expectations our scientists have that use this file type. Since NX*NY=NZ, the DAVE grouped ASCII is inherently density data. There is also no guarantee that the NX,NY points can be converted to histogram bins especially in the edge bins. Also, when converting to histogram, if the original file is density data, the bin width needs to be applied to the NZ data when converting to histogram. I'm fine with having the option, but the default behavior should be restored.

[Samuel Jackson]

Refs #8594 Make the conversion optional.

Changeset: 0bd6954693ef86a9282fa60b997d6732b2f6340f

[Samuel Jackson]

Refs #8594 Update unit tests.

Changeset: 8eb3246d5c20e0664bb62ae65301e974d9b6b371

[Samuel Jackson]

My fault. Completely failed to read the "option" part of the title. I've made it optional and added a call to ConvertFromDistribution, which (I think) takes into account the bin width as you described.

[Michael Reuter]

Merge remote-tracking branch 'origin/feature/8594_add_convert2hist_to_LoadDaveGrp'

Full changeset: ​dda6f6083adc46ed93e6e636a97ebccef03948d8

[Stuart Campbell]

This ticket has been transferred to github issue ​9438