Ticket #8631 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

DiffRotDiscreteCircle: move initialization steps from constructor to init method

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Jose Borreguero) (diff)

Both DiffRotDiscreteCircle and its members (ElasticDiffRotDiscreteCircle and InelasticDiffRotDiscreteCircle) carry out the initialization steps in their corresponding constructors. When object creation is required, but not initialization, these steps amount to a significant overhead.

Note to Tester: Follow the notes "for the tester" found in the description of ticket #8508. Run the attached python script there to verify that the changes implemented in this ticket did not affect the fitting procedure.

Change History

comment:1 Changed 7 years ago by Jose Borreguero

  • Status changed from new to inprogress

Refs #8631 Improved the value of Plank constant

Substituted 4.136 for 4.135665616 Also renamed the associated variable to m_h

modified: DiffRotDiscreteCircle.h modified: DiffRotDiscreteCircle.cpp modified: DiffRotDiscreteCircleTest.h

Changeset: 7359eb29084af2dd1be8da1a020556489225a7c9

comment:2 Changed 7 years ago by Jose Borreguero

Refs #8631 elastic part: moved constraint initialization

modified: DiffRotDiscreteCircle.h modified: DiffRotDiscreteCircle.cpp

Changeset: 4a0c9e6c7d68904e638eeb105088597c00bd63cc

comment:3 Changed 7 years ago by Jose Borreguero

Refs #8631 Inelastic part: moved constraints to init

modified: DiffRotDiscreteCircle.h modified: DiffRotDiscreteCircle.cpp

Changeset: a6ddad0f29ac4d86fbcb2395eae827be8567e351

comment:4 Changed 7 years ago by Jose Borreguero

Refs #8631 moved steps to init

modified: DiffRotDiscreteCircle.h modified: DiffRotDiscreteCircle.cpp modified: DiffRotDiscreteCircleTest.h

Changeset: 717d92ecb6e7b1ff8891d3a4c3c0ef61df3e6dde

comment:5 Changed 7 years ago by Jose Borreguero

  • Milestone changed from Backlog to Release 3.1

comment:6 Changed 7 years ago by Jose Borreguero

Refs #8631 Modified WIKI header

modified: DiffRotDiscreteCircle.cpp

Changeset: 1e040ef3801fa1bf54df014f8746ccd45bcfb15d

comment:7 Changed 7 years ago by Jose Borreguero

  • Description modified (diff)

comment:8 Changed 7 years ago by Jose Borreguero

  • Description modified (diff)

comment:9 Changed 7 years ago by Jose Borreguero

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Jose Borreguero

For the Tester: Read the notes for the tester in the description of the ticket.

comment:11 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8631_DiffRotDiscreteCircle_init'

Full changeset: ​e0f10f1b70d8c66815d7e04a5de2497462ab3443

comment:13 Changed 7 years ago by Jose Borreguero

  • Component changed from Framework to Indirect Inelastic

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9475

Note: See TracTickets for help on using tickets.