Ticket #8638 (closed: fixed)
Use workspace start time when adding time-series log with AddSampleLog
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #8637 | Tester: | Jose Borreguero |
Description
AddSampleLog uses the current time (when the algorithm is run) as the time on the single-value TSP that can be added to a workspace with this algorithm. This seems like a very strange choice. A much more useful one (and one that's required for #8637) would be to use the workspace start time. '0' - the epoch start - would be better if that's missing (though it shouldn't be for real data).
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #8638. Test for the addition of the start time.
Changeset: 70eae4659e1a2c37cc2c353cb7b8daec8f4d56d5
comment:3 Changed 7 years ago by Russell Taylor
Re #8638. Remove redundant line.
It was just setting the property to the value it already had (since it's an InOut).
Changeset: 7d5a07e41a5858beae174e8c68d228f85a0d28dc
comment:4 Changed 7 years ago by Russell Taylor
Re #8638. Add missing unit test for endTime.
Including testing for yet-to-be-implemented behaviour when the end time string is not well-formed.
Changeset: d5593ba3dffb82c7cea54d7819b0c6f494e66175
comment:5 Changed 7 years ago by Russell Taylor
Re #8638. Refactor to catch misformed times.
Changeset: 9c4b78e941d707ad7432fe7bf130e67f62415171
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
The scope of this widened from the initial simple change to AddSampleLogs when this caused a failure of the WishDiffuseScattering system test because its input data has the run start time specified as ("__"). This revealed that LogManager::startTime has no checking for whether the log that holds this attribute (which is just a string log) holds a valid date and so an unexpected exception was getting out.
So I went and modified LogManager::startTime (and endTime) to handle this situation and throw out the same exception as if the log is not even there.
Test by inspection and seeing that the unit tests confirm the expected behaviour.
comment:7 Changed 7 years ago by Russell Taylor
Re #8638. Documentation update.
Changeset: e34ed45ed0074c71a1dd2ce29b3780b61ca2724b
comment:8 Changed 7 years ago by Jose Borreguero
- Status changed from verify to verifying
- Tester set to Jose Borreguero
comment:9 Changed 7 years ago by Jose Borreguero
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8638_addsamplelog_starttime'
Full changeset: cc464ca0c518102d87e919e504b96ea740d8fbdf
comment:10 Changed 7 years ago by Jose Borreguero
everything seems fine
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9482
Re #8638. Use workspace start time for added log.
Not the time when the algorithm is run (a strange choice). If there's not start time, use the epoch (1990-1-1).
Changeset: e485be9a12f11662ae68e98f29fc10acef4d1a9d