Ticket #8663 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix test failures on Fedora 19 and 20

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: critical Milestone: Release 3.1
Component: Framework Keywords:
Cc: saviciat@… Blocked By:
Blocking: Tester: Andrei Savici

Description

One of the unit tests fails on Fedora 19 & 20, namely GeometryTest.ObjComponentTest.testSolidAngleCappedCylinderWithScaleFactor with the error: 

Error: Expected (A->solidAngle(V3D(10,2.4001,0)) == 2*3.14159265358979323846)
 up to 1e-2 (0.0100), found (3.1465 != 6.2831)

Change History

comment:1 Changed 7 years ago by Stuart Campbell

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Stuart Campbell

I have tracked it to the point that the number of triangles that are being used in the solidAngle calculation is different, on a system that works it is 280 and on Fedora 19/20 it is 556.

comment:3 Changed 7 years ago by Stuart Campbell

Changed to use atan2 rather than atan. refs #8663

Changeset: 172513107b9da1e9ee714d93bb82df30c8b146d7

comment:4 Changed 7 years ago by Stuart Campbell

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:6 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8663_solidangle'

Full changeset: ​ea5ead71b2e9d913011286e7cbe7f6eb3f8a29e1

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9507

Note: See TracTickets for help on using tickets.