Ticket #8667 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Improve user notice in FitParameter

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Follow on from #7606 add notice to user when reading fit parameter info for the case where no information is provided and where the value defaults to zero

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to inprogress

Added more warning outputs to operator>>. re #8667

Changeset: 9cae8a5346464637624e94cc5dd8d69db397738e

comment:2 Changed 7 years ago by Anders Markvardsen

done a better job at adding warnings. re #8667

Changeset: f2a6344bccacac3f48675ebad051eed7af553dd0

comment:3 Changed 7 years ago by Anders Markvardsen

To tester:

  1. load any data
  1. Open an INST_PARAMETER*.xml for the instrument of this data and add a fitting parameter like:

<parameter name="someFittingFunction:someParamOfFittingFunc" type="fitting">

<value val="ga ga" />

</parameter>

  1. Run LoadParameterFile with this INST_PARAMETER*.xml

and you should in the example above this warning message:

Could not read ga ga as double for fitting parameter: someFittingFunction:someParamOfFittingFunc

comment:4 Changed 7 years ago by Anders Markvardsen

Revert "done a better job at adding warnings. re #8667"

This reverts commit f2a6344bccacac3f48675ebad051eed7af553dd0.

Changeset: d9d78869a8a0b8ecd84620fc9928a5f0fc83a9d4

comment:5 Changed 7 years ago by Anders Markvardsen

Revert "Revert "done a better job at adding warnings. re #8667""

This reverts commit d9d78869a8a0b8ecd84620fc9928a5f0fc83a9d4.

Changeset: 9668090984e43dd529b09b8b2d7653e46e1831a5

comment:6 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8667_noticesToFitparam'

Full changeset: ​9b6688c550d19f48f07100856281ec152d0f9872

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9511

Note: See TracTickets for help on using tickets.