Ticket #8677 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

MUON: sequential fit Runs textbox edit -> start button

Reported by: Anders Markvardsen Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.1
Component: Muon Keywords:
Cc: adrian.hillier@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

  1. load HIFI run 62935 e.g.
  1. Fit anything
  1. Open sequential fitting
  1. Add HIFI62935-62937 e.g.

At the moment this text string is not processed before either a tab is pressed or user click on the Label area or Dianosis area

Enhance this to also include the Start button area

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Component changed from Framework to Muon

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

I can't see the way of fixing that without changing the way Start button works - instead of disabling it when some of the fields are invalid I should keep it enabled and show an error is some of the fields are invalid. Then I will be able to explicitly run the findFiles and wait for when searching is finished (if one was needed). This would work in the same way e.g. Load dialog works.

comment:3 Changed 7 years ago by Arturs Bekasovs

Refs #8677. Changed the way validation is done.

Added an additional "preparation" state which is when file search is done if necessary.

Changeset: 208eed3e3fbc5ae089f7ab0997123e5ac505068c

comment:4 Changed 7 years ago by Arturs Bekasovs

Refs #8677. Set appropriate cursor while waiting.

So that user is aware that something is happening.

Changeset: f1fd53ab624f570d0f5f559776329e6d979db199

comment:5 Changed 7 years ago by Arturs Bekasovs

Tester:

Make sure it is now possible to just put HIFI62935-62937 into the box and click Start. The dialog should finish the file search and run the fitting. Though if you put something like HIFI62935-629g37 and click Start it should report an error.

Confirmation should be shown when trying to fit using the same label twice and an error should be reported when trying to fit for an empty label.

Additionally, check that the waiting cursor is displayed when finishing file search and fitting, though it is still possible to stop the fit on the half-way through.

comment:6 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:8 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8677_muon_seq_run_validation'

Full changeset: ​c8b92c6dcc6539f1ab1461e9353954543850943f

comment:9 Changed 7 years ago by Anders Markvardsen

tested with HIFI62935-62936 and can now go straight to start button

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9521

Note: See TracTickets for help on using tickets.