Ticket #8709 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

LoadIDFFromNexus does more than loading IDF

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.1
Component: Framework Keywords: CORE
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

At the moment LoadIDFFromNexus does:

(1) load idf from nexus

(2) load logs info from nexus

(3) load sample info from nexus

The name of this algorithm indicates that this algorithm should do just (1).

Modify algorithm to do just (1)

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to inprogress

Made LoadIDFFromNexus load just the instrument. re #8709

Changeset: 8f3516560dd9bf5a5f24dde974da0cca73354b62

comment:2 Changed 7 years ago by Anders Markvardsen

To tester:

Check that LoadIDFFromNexus now execute ExperimentInfo::loadInstrumentFromNexus instead of loadExperimentInfoNexus.

Check that all systemtests have passed.

comment:3 Changed 7 years ago by Anders Markvardsen

update doc for to refer to new wiki page. re #8709

Changeset: e50f761b38d03233033797b357e28c96b9be461a

comment:4 Changed 7 years ago by Anders Markvardsen

Revert "update doc for to refer to new wiki page. re #8709"

This reverts commit e50f761b38d03233033797b357e28c96b9be461a.

Changeset: e6e98226a11977455b8894b38f4eca148b91aaab

comment:5 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Anders Markvardsen

  • Keywords CORE added

Added keyword core to this ticket, since LoadIDFFromNexus is used in the important loader LoadEventNexus and although the changes have kept all systemtest and units happy, here added keyword CORE to make this ticket easier identifiable should some unexpected behaviour shows in connection with loading event nexus file.

In some sense it could be argued that LoadEventNexus should use a call like ExperimentInfo::loadInstrumentFromNexus directly rather than LoadIDFFromNexus since this means one child algorithm creation less - but this is probably in the noise

comment:7 Changed 7 years ago by Anders Markvardsen

fix build server. re #8709

Changeset: a4ef1c73edf4081da7459111fc32e49e7a60aa5f

comment:8 Changed 7 years ago by Anders Markvardsen

Ups the code change was suppose to have been for re #8769. I.e. please ignore comment:7 above

comment:9 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:10 Changed 7 years ago by Karl Palmen

Code changed as required and no problem with system tests in develop branch over 2 weeks.

comment:11 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8709_loadIDF'

Full changeset: ​c907f13179fcc08e0f2bbe42a8a63c74926792ed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9553

Note: See TracTickets for help on using tickets.