Ticket #8763 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Refl_gui Improvements - Many Minor Fixes

Reported by: Keith Brown Owned by: Keith Brown
Priority: minor Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #7377 Tester: Owen Arnold

Description (last modified by Keith Brown) (diff)

There are many relatively minor issues that can be done all at once:

Add shortcuts - I will also add a new menu to publicise them.

  • Autofill - Alt + A
  • Process - Alt + P
  • Transfer - Alt + T
  • Clear All - Alt + C (Ctrl is far enough away that this can be done without fear of happening when attempting a copy)
  • Search RB - Alt + R (Can also already be done by pressing enter while the textbox has focus)

Change default Cycle depth to 5.

Add Tooltips.

  • At minimum this should be added to the first column of the table if possible, but other widgets would be good too.

Move the Polarisation corrections combobox in from the edge slightly.

Have an RB search strip out whitespace. (This merges #8750 into this ticket)

Make Autofill more vocal when it won't work. (This merges #8620 into this ticket)

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Blocking 7377 added

comment:2 Changed 7 years ago by Keith Brown

  • Priority changed from major to minor
  • Component changed from Framework to Reflectometry
  • Milestone changed from Backlog to Release 3.1

comment:3 Changed 7 years ago by Keith Brown

  • Owner set to Keith Brown

comment:4 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress
  • Description modified (diff)

Also merging #8620 into this ticket

comment:5 Changed 7 years ago by Keith Brown

Refs #8763 UI tweaks made, nothing functional yet.

New menu has been added (as this is the simplest way to add shortcuts) but they've not been wired up to a function yet.

Polarisation corrections combobox has been moved.

Tooltips added to many controls, but not the table yet as that requires editign teh functionality code.

Spinbox default value cahnged to 5.

Added a few separators to the menus.

Changeset: 330709ad0ba7a69c73cf00596925e8fe2fc2ca46

comment:6 Changed 7 years ago by Keith Brown

Refs #8763 Whitespace stripped, actions connected

Latest_isis_runs now strips the whitespace off any search string given to it

Last commit didn't actually connect the new signals. Helps if I write connect statements. I've also wired them directy to the same functions as the buttons, rather than giving them their own functions.

Changeset: ecb04ec110d2a7dbe3a19bb34f838a8db92a27d0

comment:7 Changed 7 years ago by Keith Brown

Refs #8763 Refactored atufill slgihtly and added last error

I've refactored the autofill code to inlcude less queries to the tablewidget for row numbers

The last error message has been added in the case that there were no targets to autofill.

Changeset: 123b6f49517b80e5fc3d585078a7e051ebd007b9

comment:8 Changed 7 years ago by Keith Brown

Refs #8763 Table tooltips added to runs, angle and stitch columns

Tooltips have been adde to all run(s) and angle columns to explain hidden functionality or units. Stitch? also has a rudimentary tooltip now.

Changeset: 8ba65f9ccc9cdf3c49453660fa22b3e8d08021a5

comment:9 Changed 7 years ago by Keith Brown

Refs #8763 Minor tooltip error fix

A tooltip that said 'semicolon' should have said 'comma' instead

Changeset: 19c36cc289feb09548ddf6c9b04bc7f25987bbbb

comment:10 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

Make sure all the improvements listed at the top have been implemented as well as all the functionality listed here: http://www.mantidproject.org/Testing_ISIS_Reflectometry_GUI

comment:11 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:12 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8763_Refl_gui_Many_minor_improvments'

Full changeset: 19c737a67586aec3cffea7a83587d8935fab773b

comment:13 Changed 7 years ago by Owen Arnold

refs #8763. Two code-behind changes.

Im really breaking the rules doing this directly on master. I shouldnt be making this change on master, but we badly need them tonight for user testing tomorrow. This is BAD practice, but I dont have much choice.

Changeset: 3039f3414ff3a987974668ecb221a804a7ea7a42

comment:14 Changed 7 years ago by Owen Arnold

Looks OK. Some of the tooltips on the table aren't showing up, but this could be a Mac issue. Also I think you've implemented some new keyboard shortcuts that we didn't discuss. You can't have executed the gui after you made your last set of changes because the python was invalid and I had to fix it.

comment:15 Changed 7 years ago by Keith Brown

I wasn't going to add a new menu for just two items, I was going to make it a bit more useful if i was making a new menu so I could add some shortcuts.

as for those quick extra bits you needed to do, I must have forgotten to push changes in my rush for the bus, as i did start the gui and caught the invalid bit.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9607

Note: See TracTickets for help on using tickets.