Ticket #8765 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Default Settings.xml

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By: #8755
Blocking: #7377 Tester: Keith Brown

Description

Settings.xml file should be shipped by default and pre-filled with the windows path. This will mean that it just works on windows, but also it will still be possible for non-windows users to modify the settings.xml file as they used to.

We now also have agreement that we can now use the ICAT login and search functionality within this user interface. This will mean we can kill off a lot of the journal xml parsing code that is bloating this user interface.

Change History

comment:1 Changed 7 years ago by Jay Rainey

  • Blocked By 8755 removed

(In #8755) When I try to run the GUI I get another (different) error, which is:

ImportError: No module named settings
  at line 6 in '<Interface>'
  caused by line 5 in '~/dev/testing/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py'
  caused by line 10 in '~/dev/testing/Code/Mantid/scripts/Interface/ui/reflectometer/refl_save.py'

I believe this is is to do with the change introduced here. The GUI ran correctly when I changed the import statement from:

from settings import MissingSettings, Settings

to

from isis_reflectometry.settings import *

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8765. Added the settings file.

Changeset: 21a7221b3e5659ad61a743868964706952c8f67e

comment:3 Changed 7 years ago by Owen Arnold

Tester.

Tests on Windows

  • Take a windows installer off develop
  • Install it and start it up.
  • Open the isis reflectometry gui
  • Type in 1320341 into the rb search box. Hit search
  • After a few seconds the list on the LHS should be populated

Tests on other Platforms (after testing above)

  • Try doing the same as above, should get log message about the DataMountPoint location
  • Edit the settings.xml file now shipped with MantidPlot. The DataMountPoint should be set to a local mount of the isis inst$ directory.
  • Restart the isis Reflectometry gui
  • Run through the steps above and it should work as above.

Run through the normal Reflectometry GUI tests (ask Keith for help if needed) http://www.mantidproject.org/Using_ISIS_Reflectometry_GUI#Testing

comment:4 Changed 7 years ago by Owen Arnold

refs #8765. Need settings file in correct location.

Changeset: b15ddfc3c36b9c23a2aebd25e1fcd28b3bcbd090

comment:5 Changed 7 years ago by Owen Arnold

refs #8765. Bad xml issue resolved.

Changeset: 44af2bd6a6ba57b2e5fb766e016243a553f480f5

comment:6 Changed 7 years ago by Owen Arnold

  • Blocked By 8755 added
  • Milestone changed from Backlog to Release 3.1

Waiting on #8755 to pass testing as will need to rebase these changes ontop of master before closing.

comment:7 Changed 7 years ago by Owen Arnold

refs #8765. Added the settings file.

Changeset: 62dc40e1be64e3268e8232229b086eb3a5926e3f

comment:8 Changed 7 years ago by Owen Arnold

refs #8765. Need settings file in correct location.

Changeset: ed81a2f20c6dcd6842d57fb0409521769a0845cc

comment:9 Changed 7 years ago by Owen Arnold

refs #8765. Bad xml issue resolved.

Changeset: 9677e9aef5d48f7f1fd353a8ac8b4636472dab51

comment:10 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:12 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

comment:13 Changed 7 years ago by Keith Brown

  • Blocking 7377 added

Linking 7377 to this ticket

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9609

Note: See TracTickets for help on using tickets.