Indirect ConvFit has file loading issues

[Samuel Jackson]

I get an unhandled exception if I try to run ConvFit after deleting a file it expects to exist before running. Fix it.

[Samuel Jackson]

Refs #8768 Attempt to reload file if it's been removed from ADS

Changeset: 20aaaf82d56d288abd204d82b70b56b3f5b7fb35

[Samuel Jackson]

To Tester:

First confirm you can reproduce the error:

• Open the IDA interface.
• Select ConvFit and run with any appropriate files. See this link for instructions:

http://www.mantidproject.org/Indirect:Indirect_Data_Analysis

• Now delete all the files produced, including the sample run.
• Attempt to re-run and you'll get a high level exception

Then check that the fix works. Doing the same thing should cause the LoadNexus to be run and use the file path to attempt to reload the file.

[Samuel Jackson]

Spotted that this issue is also present in FuryFit. Will attempt similar solution.

[Samuel Jackson]

Refs #8768 Fix duplicate issue in FuryFit.

Changeset: b108c1353a95ab7f0f5155846a1a98515f310a78

[Samuel Jackson]

To Tester:

As above, but do it for FuryFit as well. (Use Fury to output a file that can be run with FuryFit).

[Jay Rainey]

The two exceptions noted in this ticket have been dealt with accordingly.

When running Fury it completes successfully. However, I came across a few other issues when testing other IDA interfaces to verify they did not have the same problem. The problem encountered was:

1. When running Fury if I delete all of the workspaces (while the GUI is open) and click Run nothing happens and an error is thrown:

ValueError: Invalid value for property Filename (string) "irs26174_graphite002_red.nxs": File "irs26174_graphite002_red.nxs" not found
  at line 3 in '<Interface>'
  caused by line 566 in 'C:/MantidInstall/bin\mantid\simpleapi.py'
  caused by line 530 in 'C:/MantidInstall/bin\mantid\simpleapi.py'

Re-opened as this issue is related to those in the ticket.

[Samuel Jackson]

Refs #8768 Use full file path when reloading.

This will only effect users loading a file outside their managed directories.

Changeset: c0d0bdd74cfb28fefa61cf8fdd77fd763ea0690e

[Samuel Jackson]

To Tester: As above, but just check Fury this time.

[Jay Rainey]

The change in comment:10 address the issue I noted in comment:8 (this occurred as I did not have the directory of the datafiles setup in my 'Manage directories'). The other changes implemented solve the problem, and an unhanded exception is no longer thrown. There are no CPP warnings, and the code appears to be correct.

[Jay Rainey]

Merge remote-tracking branch 'origin/bugfix/8768_convfit_file_loading_issues'

Full changeset: ​3b91b4c9aa41698423d66c346b7134f61b9c3e78

[Stuart Campbell]

This ticket has been transferred to github issue ​9612