Quick should co-add

[Owen Arnold]

While we are still using the quick script (hopefully not for much longer). We need to ensure that the co-add features (read sum-spectra) are accessible. Traditionally this has been done using a colon to separate runs which are to be co-added prior to processing. We need to add the ability to specify comma and colon separated runs as an argument to quick.

[Owen Arnold]

refs #8780. Add ability to coadd via commas and colons

Changeset: 34e79c21a52fa8aedbd908a70148da5a48754e1c

[Owen Arnold]

Tester: The following shows the effect of coadding runs. All you need to verify is that the two lines on the plots that are produced are different.

from isis_reflectometry.quick import *
config['default.instrument'] = 'INTER'
LoadISISNexus(Filename='13460', OutputWorkspace='13460')
LoadISISNexus(Filename='13464', OutputWorkspace='13464')
 
quick(run='13460', theta=0.7)
one = CloneWorkspace('13460_IvsLam')

quick(run='13460, 13464', theta=0.7)
two = CloneWorkspace('13460_IvsLam')

plotSpectrum([one, two], 0)

I have added unit tests for the splitting. You should also verify that There are sufficient system tests for the existing functionality of this script, so make sure the system tests are passing.

[Owen Arnold]

(In #8783) Your fix af99d3bb61a869984ba9ab98f1577c2c0fa39f0b is only develop, not on your feature branch. The correct thing to do is to set #8780 as a blocker to this ticket, and then merge master into this branch once that ticket has passed. That way you can apply your changset again, and everything should work nicely.

[Owen Arnold]

Keith has reported failures with this functionality.

[Owen Arnold]

Tester. This should produce the same results as the above example where a comma is used.

from isis_reflectometry.quick import *
config['default.instrument'] = 'INTER'
LoadISISNexus(Filename='13460', OutputWorkspace='13460')
LoadISISNexus(Filename='13464', OutputWorkspace='13464')
 
quick(run='13460', theta=0.7)
one = CloneWorkspace('13460_IvsLam')

quick(run='13460:13464', theta=0.7)
two = CloneWorkspace('13460_IvsLam')

plotSpectrum([one, two], 0)

[Owen Arnold]

refs #8780. regex splitting needs extending

Changeset: 4e6837d1632138377edf4f6e6a03b1e5a2bf8906

[Owen Arnold]

refs #8780. Merge branch 'feature/8780_coadd_in_quick' into develop

Conflicts:

Code/Mantid/scripts/Reflectometry/isis_reflectometry/convert_to_wavelength.py

Changeset: a06c037df382635049c095d023c26afe7e23459d

[Owen Arnold]

Unit tests and system tests checked. Should be working fine now.

[Keith Brown]

Merge remote-tracking branch 'origin/feature/8780_coadd_in_quick'

Full changeset: ​20d169175c06f8782e3f333f55f404dc37407291

[Keith Brown]

Works with colons now

[Stuart Campbell]

This ticket has been transferred to github issue ​9624