Ticket #8783 (closed: fixed)
Quick.py cleanup
| Reported by: | Keith Brown | Owned by: | Keith Brown |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.1 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | #8780 | |
| Blocking: | Tester: | Owen Arnold |
Description
Quick currently generates a lot of workspaces while it's working and should clean them up afterwards, but it's not.
There's apparently a cleanup method that should delete any workspace prefixed with an underscore, but that doesn't seem to work. And there are some that aren't prefixed that need to be.
Change History
comment:2 Changed 7 years ago by Keith Brown
Refs #8783 Merge branch 'feature/8783_quick_cleanup' into develop
Conflicts:
Code/Mantid/scripts/Reflectometry/isis_reflectometry/convert_to_wavelength.py
Changeset: af99d3bb61a869984ba9ab98f1577c2c0fa39f0b
comment:3 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:5 Changed 7 years ago by Owen Arnold
- Status changed from verifying to reopened
- Resolution fixed deleted
- Blocked By 8780 added
Your fix af99d3bb61a869984ba9ab98f1577c2c0fa39f0b is only develop, not on your feature branch. The correct thing to do is to set #8780 as a blocker to this ticket, and then merge master into this branch once that ticket has passed. That way you can apply your changset again, and everything should work nicely.
comment:7 Changed 7 years ago by Keith Brown
good thing it was reopened, found out there was at least one i missed
comment:8 Changed 7 years ago by Keith Brown
- Status changed from reopened to inprogress
Refs #8783 Polarisation correction temp ws cleanup
I'd missed some workspaces used when performing polarisation corrections
Changeset: 1f4ba4e7b6f66fc896b938fbc69d2075af595bc6
comment:9 Changed 7 years ago by Keith Brown
Refs #8783 Merge remote-tracking branch 'origin' into feature/8783
Conflicts:
Code/Mantid/scripts/Reflectometry/isis_reflectometry/convert_to_wavelength.py
Changeset: dc015dd47f205ed44b22bd87f5455189f103bdda
comment:10 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester:
This ticket just changed the underlying scripts, but the gui needs tested too
Make sure all the features of the Reflectometry gui still work.
- General use instructions - http://www.mantidproject.org/ISIS_Reflectometry_GUI
- Testing instructions - http://www.mantidproject.org/Testing_ISIS_Reflectometry_GUI
- Example - http://www.mantidproject.org/ISIS_Reflectometry_Examples
The only workspaces that should be left after processing are [run]IvsQ and [run]IvsLam plus any rebinned or stitched workspaces that have been plotted
comment:13 Changed 7 years ago by Owen Arnold
Merge remote-tracking branch 'origin/feature/8783_quick_cleanup'
Full changeset: 6e2023f518fbf827c2908349777dcf36837c4f54
comment:14 Changed 6 years ago by Keith Brown
- Summary changed from Quick cleanup to Quick.py cleanup
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9627
Refs #8783 quick now cleans up
Quick and convert_to_wavelength were creating workspaces that weren't prefixed by an _
Quick was never calling cleanup because of a logical check which always evaluated to false under normal use
Changeset: 2a84c4bdea97e6367666346bcb99b0eab9ca2a94