Ticket #8802 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ConvFit option to choose component

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Jose Borreguero

Description

We should supply an option of whether to convolve or not. Speak to Spencer for more details.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:3 Changed 6 years ago by Dan Nixon

  • Cc spencer.howells@… added
  • Milestone changed from Backlog to Release 3.3

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added option to convolve to conv fit

Refs #8802

Changeset: 43fd2045c31d4b9a6649632df43d407c8ed74610

comment:5 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/8802_convolve_option_for_conv_fit

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui

Refs #8802

Changeset: fbc160f218bcdfc2860d976b669ddc60bcc88210

comment:6 Changed 6 years ago by Dan Nixon

Move convolve option to property tree

Refs #8802

Changeset: 2f30b2d34cb149af7fd6455544ba80b1190b8ace

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Open Indirect > Data Analysis > ConvFit
  • Load sample irs26176_graphite002_red.nxs (from systemtests/Data)
  • Load resolution irs26173_graphite002_res.nxs (from systemtests/Data)
  • Click "Run", open one of the result workspaces in data view
  • Notice the 5th spectrum is the convolution of the fitted Lorentzian and the resolution
  • Uncheck Convolve and run again
  • Notice now there is the Lorentzian and resolution without convolution

comment:8 Changed 6 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:9 Changed 6 years ago by Jose Borreguero

Works as expected

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'master' into feature/8802_convolve_option_for_conv_fit

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataAnalysis.ui

Refs #8802

Full changeset: ​fbc160f218bcdfc2860d976b669ddc60bcc88210

comment:11 Changed 6 years ago by Jose Borreguero

Merge remote-tracking branch 'origin/feature/8802_convolve_option_for_conv_fit'

Full changeset: ​8dd7a404c72276adf389ce6d9fa091aa2ed19959

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9646

Note: See TracTickets for help on using tickets.