Ticket #8810 (closed: fixed)
Add functions which return transformation limits for ConvertToMD transf factory methods
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | saviciat@… | Blocked By: | |
| Blocking: | Tester: | Andrei Savici |
Description
This ticket is part of #7529.
The transformation methods used in ConvertToMD should be able to return ranges where the transformation is monotonic
Change History
comment:2 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.1 to Backlog
Moved to backlog at the end of Release 3.1
comment:3 Changed 7 years ago by Alex Buts
refs #8810 roughly written the methods to identify the limits
for ConvToMD transformations
Changeset: 7ed3d0ac02eef04b570c85aa0793adef94e247bb
comment:4 Changed 7 years ago by Alex Buts
refs #8810 should be working MDRange function
at least assuming that the Transf matrix is a rotation.
Changeset: 7c25bbeb460be2b260058cad2a8b0fe6b5e946b1
comment:5 Changed 7 years ago by Alex Buts
refs #8810 unit test for ModQ transformation ranges
Changeset: 9b3c5df19bdb82e6c19dd58f122ed295b0db6cdb
comment:6 Changed 7 years ago by Alex Buts
refs #8810 Unix warnings
Changeset: 355c6f74d3b9d50241e1d151ecf1c0923f3c5f0a
comment:7 Changed 7 years ago by Alex Buts
- Cc saviciat@… added
- Status changed from inprogress to verify
- Resolution set to fixed
- Milestone changed from Backlog to Release 3.1
This change adds to convertToMD transformations a method, which returns X coordinates where MD coordinate transformation can reach an extremum.
I am marking this thicket as fixed because currently in convertToMD in modQ mode we do not use anything but unit transformation matrix. As this ticket is needed for #7529 and the unit transformation matrix is much easier to understand and test then anything else, it is good enough for now. General case can be trivially (but bulky) done later if necessary.
It appears to be that all MD transformations are monotonic except ModQ in direct and indirect mode where maximal momentum transfer depends on the detector position and the energy transfer value.
Anybody and especially Andrei can easy check it by looking at the derivative of the coordinate transformation or any component of the transformation.
The changes to code itself are simple and can be easily understood/verified by code review.
comment:8 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:9 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to verify
- Tester Roman Tolchenov deleted
Cannot verify this ticket
comment:10 Changed 7 years ago by Alex Buts
refs #8810 Missing return operator in elastic case.
Changeset: 5ad7d1938c8f7e69edb72849964a73376523d151
comment:11 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:12 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8810_conv2MDRanges'
Full changeset: 147f88609eebaabc501f8201d8bffea404816023
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9654
refs #8810 Template for the method
nothing of essence yet.
Changeset: 8e6dfa7d0f63794ab8b2edc3c8aef13cf57488dc