Ticket #8820 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Indirect C2E: Create Info table option only works for TOSCA

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description

The C2E interface has an option to output a table containing run information when running a reduction. But this does nothing for OSIRIS or IRIS.

We have two options here:

  • Output a similar table for table OSIRIS/IRIS
  • Remove/disable the option for OSIRIS/IRIS

Speak with Sanghamitra to confirm the appropriate action.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Component changed from Framework to Indirect Inelastic

comment:2 Changed 7 years ago by Samuel Jackson

Spoken with TOSCA scientist. This option can just be removed as all the information is already in the sample logs.

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #8820 Remove option from interface.

Changeset: 9f863444b60c64f578f4e390ac504b19f4d938a2

comment:5 Changed 7 years ago by Samuel Jackson

Refs #8820 Remove redundant code from MSG reducer.

Changeset: 6edca7b42cab893c4a733a2a7901fbd1b662d283

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

I've removed the option for the Indirect C2E interface for all instruments. As mentioned above, all of the information is available in the sample logs anyway. Check that energy conversion still works and that the changes look good.

comment:7 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

The Create Info Table option in the interface and all references to create_info_table in Python have been removed. The energy conversion still works.

comment:9 Changed 7 years ago by Jay Rainey

Merge remote-tracking branch 'origin/bugfix/8820_tosca_create_table_option'

Full changeset: ​a42e5e763fefc9812354e7f528891d06d58a1af9

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9661

Note: See TracTickets for help on using tickets.