Ticket #8824 (closed: fixed)
Indirect C2E: tabs should limit using a peak min/max range
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.2 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Alex Buts |
Description (last modified by Samuel Jackson) (diff)
Currently the peak min/max and back min/max can be set to a value below or above the range of the spectrum. This is also the case for Spectra min/max, background and rebinning for the resolution file.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #8824 Add method to set range limits on plot and double manager
Changeset: a42604350ce01adc3f5ff01082616b4dc77579b7
comment:3 Changed 7 years ago by Samuel Jackson
Refs #8824 Update plotting routines in indirect C2E
Changeset: e88c08fdfd402240af0ec334a84cd1219d6da052
comment:4 Changed 7 years ago by Samuel Jackson
Refs #8824 Add namespace qualifier for failing windows builds.
Changeset: a0971bf229ee9d7943ac27d1d19472cc7181c911
comment:6 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
- Summary changed from Indirect C2E: Calibration tab should limit using a peak min/max range to Indirect C2E: tabs should limit using a peak min/max range
To Tester
I changed all of the plots in Indirect Convert To Energy to ensure you cannot choose a range greater than the limits of the data and ensure that the user can only choose a range that makes sense.
comment:7 Changed 7 years ago by Alex Buts
- Status changed from verify to verifying
- Tester set to Alex Buts
comment:8 Changed 7 years ago by Alex Buts
refs #8824 Windose unhappy without MantidQT namespace
and though it can be compiled in some convoluted way, (and probably did on Jenkins) it is much better to have it declared.
Changeset: 190e753b4c4d55c4e4298f4230601a30f704c39e
comment:9 Changed 7 years ago by Alex Buts
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8824_peak_min_max_limits'
Full changeset: b04405e3b76909c32dce1863bf12561c2a387782
comment:10 Changed 7 years ago by Alex Buts
ticket does what advertised but I am not sure if the chosen solution is the best.
Currently algorithm refuses to change the limits of fitting or integration or whatever if one tries to set it outside of the limits of the data. It does not warn -- just does nothing.
As a user I would initially think that it is something wrong with Mantid as it silently not accepting the changes.
Much better option would be:
1) set limits on the range (if I am changing limit this way, I would probably want it to be different from the current one and most common error is not to know exactly where the limit is -- just trying to set it higher or lower. And very often -- on the edge. Current implementation forces me to know what the number for the edge is and in most cases this is annoying)
2) warn a user that the limit has been changed to the maximal/minimal value allowed.
Current behaviour is a bit confusing.
As I am not the customer for this ticket, I am not failing this and accepting the change as it is but suggesting, I think, better behaviour.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9668
