Ticket #8830 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Indirect Bayes: Output proper errors/warnings

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description (last modified by Samuel Jackson) (diff)

I've noticed that internally, the Bayes scripts output errors to the results log at the notice level of logging. The should really report proper errors to be consistent with the other interfaces.

e.g. running Quasi with an invalid resolution file produces something like the following: 

ERROR *** Sample (osi95119_graphite002_Correct_95157_red) histograms (42) not = Resolution (irs59330_graphite002_red) histograms (51)

Additionally, running Quasi with a stretched exponential and a *_red file no longer throws an error, when it should.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Description modified (diff)

comment:2 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.2

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8830 convert bayes error notices to proper python exceptions.

Changeset: 6ded2683bf4221f30f7154a96df9570e1d95a72a

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8830 Fixed similar issues in IndirectCommon

Changeset: d6b9b497f144bc3f4eb963f18aae9f82067351bd

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

Code inspection is the most logical choice, but you may also wish to run the IndirectBayes scripts to check nothing is broken. The notice level error output should be gone and replaced with Python exceptions being thrown.

If you decide to run the Bayes programs you will need to compile Mantid on Windows in Release mode

comment:6 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:7 Changed 7 years ago by Jay Rainey

Error messages have been significantly improved. I ran it on Windows mode in Release mode to verify that the Bayes programs work as expected - they do.

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8830_bayes_output_errors_and_warnings'

Full changeset: ​97738fdb76222377822ebe9d86a21ec6766d2e18

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9674

Note: See TracTickets for help on using tickets.